Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a way to easily check cluster status #2503

Closed
sazzad16 opened this issue Apr 7, 2021 · 3 comments
Closed

Introduce a way to easily check cluster status #2503

sazzad16 opened this issue Apr 7, 2021 · 3 comments

Comments

@sazzad16
Copy link
Contributor

sazzad16 commented Apr 7, 2021

Expected behavior

There should be a easy to check if the cluster is initialized properly. I.e. if there is a pool initialized for each hash slot.

For example, if we add a isInitialized(), users would at least be able to do

JedisCluster cluster = new JedisCluster(...);
if (!cluster.isInitialized()) {
  ...
}

Actual behavior

Currently it can be done by getClusterNodes(), may be combining with a command, like PING. But we should introduce a easier way.

@sazzad16
Copy link
Contributor Author

sazzad16 commented Apr 7, 2021

Ref #2275: I don't completely support throwing exception because we don't do that even from Jedis class. Throwing exception from JedisCluster constructor seems contradictory to me.

@sazzad16 sazzad16 added this to the 3.7.0 milestone Apr 7, 2021
@sazzad16 sazzad16 modified the milestones: 3.7.0, 3.8.0 Aug 7, 2021
@sazzad16 sazzad16 modified the milestones: 3.8.0, 4.1.0 Dec 3, 2021
@sazzad16 sazzad16 removed this from the 4.1.0 milestone Jan 14, 2022
Copy link

github-actions bot commented Jan 3, 2024

This issue is marked stale. It will be closed in 30 days if it is not updated.

@github-actions github-actions bot added the stale label Jan 3, 2024
@sazzad16 sazzad16 removed the stale label Jan 3, 2024
@sazzad16
Copy link
Contributor Author

sazzad16 commented Oct 8, 2024

  1. JedisCluster constructors now throws an exception if it cannot connect to any HostAndPort (throw exception if JedisCluster cannot connect to any host-port #2721)
  2. JedisCluster now has PING command that accumulates responses from all nodes (OSS Broadcast support #3285)

Closing this issue in favor of these options.

@sazzad16 sazzad16 closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant