Port RESP3 support from Redis. #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corresponds to commits d5c54f0b..bea09a7f in the redis repository.
|
I'm willing to create tests but I think we should probably merge this. |
|
My goal here is to merge RESP3 changes made by @antirez back to mainline hiredis, so the latest (with SSL support) can be used in |
|
This merge broke MSVC builds. These kind of problems could be prevented if PR branches are rebased on top of the latest master before merging. That way the tested code represents the post-merge state, and the latest builds & tests from master will be run on the PR. See: https://www.bitsnbites.eu/a-stable-mainline-branching-model-for-git/, The importance of staying on the latest master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the RESP3 support added to the hiredis version bundled as part of Redis.