Request: RESP 3 support

[schlitzered]

hi, i am the author of one of the python redis implementations, and i am currently working on implementing resp3 in my fallback parser.

are there already plans to support RESP 3? if yes how are you planning to implement protocol switching?

this is somehow important because with RESP 3 parsers/clients are expected to return programming language native responses, like dicts, lists or sets.

since i mimic the api of hiredis-py, i would think it would be nice if there is a function to tell the parser to switch protocols.

something like parsert.protocol = 3

what do you think?

Kind regards

[ifduyue]

Hello,

Currently no plan to support RESP3.
hiredis-py is a wrapper of hiredis. Unless hiredis supports RESP3, hiredis-py will not support RESP3.

[bsergean]

It looks like this PR added RESP3 support to the mainline.

redis/hiredis#697

[ifduyue]

Noticed. I think we need to write a pure python reader if we want to continue the support for windows.

[bsergean]

You probably are aware of different pure python reader, but one I know of is embedded in aredis. (class PythonParser) https://github.com/NoneGG/aredis/blob/master/aredis/connection.py#L175 There isn't much code it's funny ...

…

On Feb 25, 2020, at 5:36 AM, ifduyue ***@***.***> wrote: Noticed. I think we need to write a pure python reader if we want to continue the support for windows. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#84?email_source=notifications&email_token=AC2O6UKHCTNCB4QJFUT4LELREUNFVA5CNFSM4G4XQXB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM37LEQ#issuecomment-590869906>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UNA5SPVR7RCPPJE6FDREUNFVANCNFSM4G4XQXBQ>.

[ifduyue]

redis-py has a pure python parser, too

[ifduyue]

These two parsers aren't RESP3 yet

[bsergean]

If the hash-table (%) the only addition in the term of data type that you know of for RESP 3 ?

…

On Feb 26, 2020, at 4:38 AM, ifduyue ***@***.***> wrote: These two parsers aren't RESP3 yet <https://user-images.githubusercontent.com/568900/75345297-6a214680-58d7-11ea-8d02-4ebf8ff238c9.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#84?email_source=notifications&email_token=AC2O6UKAQLONQITWXJJ6N5TREZPDLA5CNFSM4G4XQXB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENAB7SY#issuecomment-591405003>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UNTY6QHOICZNA66SXTREZPDLANCNFSM4G4XQXBQ>.

[michael-grunder]

No there are a ton of new types

• , - DOUBLE
• _ - NIL
• % - MAP
• ~ - SET
• # - BOOL
• ! - BLOB ERROR
• = - VERTBATIM STRING
• ( - BIG NUMBER
• < - PUSH (e.g. CLIENT TRACKING)

Edit: Initially forgot <

[Harrison88]

I've been implementing a Python RESP3 parser here, if that's helpful at all: https://github.com/Harrison88/redtrio/blob/master/src/redtrio/lowlevel/protocol.py

[schlitzered]

@Harrison88: nice, i will take a look at the implementation later. would you might consider putting the parser into a separate package?

then i could make use of it in https://github.com/schlitzered/pyredis.

[Harrison88]

@schlitzered It's now available here: https://github.com/Harrison88/respy3