This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Increase the ha-proxy timeout on the workspace agent route
#768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
|
Can one of the admins verify this patch? |
ibuziuk
approved these changes
Jul 19, 2018
garagatyi
approved these changes
Jul 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR allows setting the ha-proxy timeout for the ws-agent route to a longer value (10 minutes by default) for workspace PODs.
This is necessary to support long synchronous calls to the ws-agent API, such as a Git clone of a large repository.
What issues does this PR fix or reference?
No precise issue on this, but the problem was encountered in the context of issue #729
How have you tested this PR?
Yes, on Dev-cluster, and this allowed the vertx eclipse factory to work again.