Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Fix migrated factories that don't work fully and push the new list to Eclipse #729

Closed
davidfestal opened this issue Jul 2, 2018 · 11 comments
Assignees

Comments

@davidfestal
Copy link
Member

No description provided.

@ibuziuk
Copy link
Member

ibuziuk commented Jul 10, 2018

@davidfestal could you please list osio incompatible docker images that are used in factories

@davidfestal
Copy link
Member Author

@ibuziuk @l0rd @slemeur @benoitf @eivantsov

I ran the migration in the dedicated OSIO user on production, and I'm currently summarizing migration / test results for each factory in the following document which I shared for comments: https://docs.google.com/spreadsheets/d/1JpA3uSjfneeAqeNcchwmI1T0sxpO_o_FTaTAiVl0IIw/edit?usp=sharing

@davidfestal
Copy link
Member Author

davidfestal commented Jul 11, 2018

After discussing with @slemeur and @benoitf and commenting in this document, here is the work to be done:

  1. Fix the factories that start but don't work fully:
  • Update the Wildfly factory to in fact point to the Wildfly Swarm OSIO booster => DONE
  • Fix the PHP factory (or the underlying eclipse/php docker image) to allow the apache server to be started as regular user (instead of using sudo) => DONE
  • Fix the vertx factory to use the last vertX 3 examples repo )=> ALREADY THE CASE
  • Fix a bug that happens at factory start in the vertX and Jenkins factories related to Git cloning being done asynchronously => DONE for Vertx (new issue created for Jenkins)
  • Update the NodeJs example that seems ti use a very old example project with disappeared dependencies (grunt, etc ...) => DONE
  1. Remove the factories that we don't use anymore => DONE
  2. Prepare an alternate page on eclipse.org (visible only by us) => DONE
  3. Push the new json list of factories on this new page. => DONE

@davidfestal davidfestal changed the title Fix incompatible docker images for factories migrated from the eclipse / codenvy site Fix migrated factories that don't work fully and push the new list to Eclipse Jul 11, 2018
@ibuziuk ibuziuk added this to the Sprint #152 milestone Jul 11, 2018
@slemeur
Copy link

slemeur commented Jul 11, 2018

Sounds good. Thanks @davidfestal

@davidfestal
Copy link
Member Author

The migrated / fixed factories are available on the following additional page of the eclipse web-site:
https://www.eclipse.org/che/getting-started/cloud-osio-preview/
to be started in the prod-preview OSIO instance.
Would be great if @ibuziuk @l0rd @slemeur @benoitf could also try them and report anything that doesn't work as it was in codenvy.io

Since the telemetry factory support has been merged to master, you can follow the created / used factories here: https://www.woopra.com/live/project/test.openshift.io/reports/analytics/ujyyyn0bw9

I still have to investigate the bug that happens at factory start in the vertX and Jenkins factories, and seems related to Git cloning being done asynchronously.

@davidfestal
Copy link
Member Author

I still have to investigate the bug that happens at factory start in the vertX and Jenkins factories, and seems related to Git cloning being done asynchronously.

The error encountered in the VertX factory is now fixed by PR #768.
However, the Jenkins factory (probably the one with the biggest Git repository) still fails: during the initial project import, the JGit clone action fails on the server-side.
We agreed to open an new issue for this bug that seems to require a certain amount of additional work before understanding what's going on.

For now the Jenkins factory has been removed from the list of factories available in the Eclipse Web site, and the following issue has been created to track this bug separately: #772

So it seems that factories are ready for migration on both:

We should be able to do the switch as soon as other concerns (authorization flow for new users, etc ...) are fixed.

@davidfestal davidfestal self-assigned this Jul 24, 2018
@ibuziuk
Copy link
Member

ibuziuk commented Jul 24, 2018

We should be able to do the switch as soon as other concerns (authorization flow for new users, etc ...) are fixed.

@davidfestal have you got a chance to chat with @sbose78 about the possibility of the auto-provisioning for users that are redirected to the registration page from the factory link ?

@davidfestal
Copy link
Member Author

davidfestal commented Jul 24, 2018

@davidfestal have you got a chance to chat with @sbose78 about the possibility of the auto-provisioning for users that are redirected to the registration page from the factory link ?

I've been discussing the subject with him yesterday, and made further tests today. I was planning to add comments related to that in issue openshiftio/openshift.io#3814. @ibuziuk Do you confirm it would be a good place ?

I have some ideas that I still have to formalize a bit before providing a proposal.

@l0rd
Copy link
Contributor

l0rd commented Jul 24, 2018

@davidfestal yes I think openshiftio/openshift.io#3814 is the good issue to add the comments

@davidfestal
Copy link
Member Author

@davidfestal yes I think openshiftio/openshift.io#3814 is the good issue to add the comments

done: openshiftio/openshift.io#3814 (comment)

@ibuziuk
Copy link
Member

ibuziuk commented Aug 1, 2018

Closing since there are relevant sub-tasks already opened

@ibuziuk ibuziuk closed this as completed Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants