Commenting project list -o json CI flake #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammedzee1000
approved these changes
Jul 22, 2020
openshift-ci-robot
added
the
lgtm
Codecov Report
@@ Coverage Diff @@
## master #3620 +/- ##
=======================================
Coverage 45.50% 45.50%
=======================================
Files 116 116
Lines 11712 11712
=======================================
Hits 5330 5330
Misses 5862 5862
Partials 520 520 Continue to review full report at Codecov.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
commenting flake test as it was previously
What does does this PR do / why we need it:
I actually uncommented a test scenario through #3546 which is again hitting the same flake as reported in #2117 (Bot closed it). So commenting the spec again and reopening the issue for triage.
Which issue(s) this PR fixes:
Fixes NA
PR acceptance criteria:
Unit test : NA
Integration test : NA
Documentation : NA
How to test changes / Special notes to the reviewer:
Flake scenario is commented as it was.