-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting template based test to multi-stage testing #9431
Porting template based test to multi-stage testing #9431
Conversation
b1ab4a8
to
c00f990
Compare
/retest |
/refresh |
/test pj-rehearse |
/retest |
/test pj-rehearse |
1 similar comment
/test pj-rehearse |
/test pj-rehearse |
1 similar comment
/test pj-rehearse |
@prietyc123 similar failure i can observe in template based test aswell - https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/9427/rehearse-9427-periodic-ci-openshift-odo-master-v4.2-integration-e2e-periodic/6 I don't think your failure is specific to the multi-stage migration. Considering this is a temporary glitch, i am re running the test. Otherwise it better to involve platform team /retest |
c00f990
to
1d002a7
Compare
/retest |
/refresh |
/test pj-rehearse |
76fe05b
to
f559654
Compare
/retest |
654a233
to
6b3a624
Compare
2de0767
to
25c4e0c
Compare
/retest |
25c4e0c
to
1e4bd9a
Compare
Its a flake resolved through pr redhat-developer/odo#3620 /retest |
- as: integration-e2e | ||
commands: scripts/openshiftci-presubmit-all-tests.sh | ||
openshift_installer_src: | ||
- as: integration-e2e-steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove steps from the test name ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have nested steps and we can not use same name for both the steps in line 28 and 32 https://github.com/openshift/release/pull/9431/files#diff-cf06122cc7ac596bba3930b965d2e59bR28-R32 . I have already checked that it won't work in that way. So IMO integration-e2e-steps
best suit for this. Anyway I am open to any test name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same name is being reflected in job name.
The job name we have been using since long time should not be change for no cause. So you can rename this as - as: integration-e2e
and update the name https://github.com/openshift/release/pull/9431/files#diff-cf06122cc7ac596bba3930b965d2e59bR32 to - as: integration-e2e-steps
to avoid any conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same name is being reflected in job name.
The job name we have been using since long time should not be change for no cause. So you can rename this as
- as: integration-e2e
and update the name https://github.com/openshift/release/pull/9431/files#diff-cf06122cc7ac596bba3930b965d2e59bR32 to- as: integration-e2e-steps
to avoid any conflict.
This makes sense to me as well 👍
1e4bd9a
to
11c29e7
Compare
@petr-muller Thanks for all your valuable inputs through out the multistage migration for odo test. |
LGTM |
@prietyc123: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Trusting ur judgment on this @amitkrout |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amitkrout, girishramnani, mik-dass, mohammedzee1000, prietyc123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@prietyc123: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue Ref : redhat-developer/odo#3270
Followed multistage documentation https://ci-operator-configresolver-ui-ci.apps.ci.l2s4.p1.openshiftapps.com/help and used the ipi-aws workflow