Skip to content

Commit

Permalink
style(DesktopViewer): use standard button size in DesktopViewer (patt…
Browse files Browse the repository at this point in the history
…ernfly#1129)

Prior this fix, the Launch buttons firing file download were "btn-lg".
This looks weird in some use-cases (like OpenShift).

If the button size needs to be biger in rare cases, it can be tweaked via custom styling.
  • Loading branch information
mareklibra authored and jeff-phillips-18 committed Jan 7, 2019
1 parent 4eed95d commit 758b23f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ const ConnectWithRemoteViewer = ({
<div className="remote-viewer-pf">
<h2>{textDesktopConnection}</h2>
<div className="remote-viewer-pf-launch">
<Button className="remote-viewer-pf-launch-vv" bsSize="large" onClick={onClickVV} disabled={!console}>
<Button className="remote-viewer-pf-launch-vv" onClick={onClickVV} disabled={!console}>
{textConnectWithRemoteViewer}
</Button>
{!!rdp && (
<Button bsSize="large" onClick={onClickRDP} className="remote-viewer-pf-launch-rdp">
<Button onClick={onClickRDP} className="remote-viewer-pf-launch-rdp">
{textConnectWithRDP}
</Button>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`DesktopViewer custom topClassName 1`] = `
class="remote-viewer-pf-launch"
>
<button
class="remote-viewer-pf-launch-vv btn btn-lg btn-default"
class="remote-viewer-pf-launch-vv btn btn-default"
disabled=""
type="button"
>
Expand Down Expand Up @@ -52,7 +52,7 @@ exports[`DesktopViewer empty 1`] = `
class="remote-viewer-pf-launch"
>
<button
class="remote-viewer-pf-launch-vv btn btn-lg btn-default"
class="remote-viewer-pf-launch-vv btn btn-default"
disabled=""
type="button"
>
Expand Down Expand Up @@ -90,7 +90,7 @@ exports[`DesktopViewer with Spice and VNC 1`] = `
class="remote-viewer-pf-launch"
>
<button
class="remote-viewer-pf-launch-vv btn btn-lg btn-default"
class="remote-viewer-pf-launch-vv btn btn-default"
type="button"
>
Launch Remote Viewer
Expand Down Expand Up @@ -222,13 +222,13 @@ exports[`DesktopViewer with Spice, VNC and RDP (different hostname) 1`] = `
class="remote-viewer-pf-launch"
>
<button
class="remote-viewer-pf-launch-vv btn btn-lg btn-default"
class="remote-viewer-pf-launch-vv btn btn-default"
type="button"
>
Launch Remote Viewer
</button>
<button
class="remote-viewer-pf-launch-rdp btn btn-lg btn-default"
class="remote-viewer-pf-launch-rdp btn btn-default"
type="button"
>
Launch Remote Desktop
Expand Down Expand Up @@ -412,13 +412,13 @@ exports[`DesktopViewer with Spice, VNC and RDP 1`] = `
class="remote-viewer-pf-launch"
>
<button
class="remote-viewer-pf-launch-vv btn btn-lg btn-default"
class="remote-viewer-pf-launch-vv btn btn-default"
type="button"
>
Launch Remote Viewer
</button>
<button
class="remote-viewer-pf-launch-rdp btn btn-lg btn-default"
class="remote-viewer-pf-launch-rdp btn btn-default"
type="button"
>
Launch Remote Desktop
Expand Down Expand Up @@ -666,14 +666,13 @@ exports[`DesktopViewer with custom more-info content 1`] = `
active={false}
block={false}
bsClass="btn"
bsSize="large"
bsStyle="default"
className="remote-viewer-pf-launch-vv"
disabled={false}
onClick={[Function]}
>
<button
className="remote-viewer-pf-launch-vv btn btn-lg btn-default"
className="remote-viewer-pf-launch-vv btn btn-default"
disabled={false}
onClick={[Function]}
type="button"
Expand Down

0 comments on commit 758b23f

Please sign in to comment.