style(DesktopViewer): use standard button size in DesktopViewer #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior this fix, the Launch buttons firing file download were "btn-lg". This looks weird in some use-cases (like OpenShift). If the button size needs to be biger in rare cases, it can be tweaked via custom styling.
|
Former design with large buttons as they do not fit the rest of the page:
|
|
PatternFly-React preview: https://1129-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3774
💛 - Coveralls |
jeff-phillips-18
approved these changes
Jan 7, 2019
priley86
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior this fix, the Launch buttons firing file download were "btn-lg".
This looks weird in some use-cases (like OpenShift).
If the button size needs to be biger in rare cases, it can be tweaked via custom styling.
What: use standard button size in DesktopViewer
Additional issues: