Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix-3171 #24

Merged

Conversation

Jooho
Copy link

@Jooho Jooho commented Oct 6, 2023

This is a hotfix for kserve#3172

upstream is not merged yet but Dell poc needs this change so a quick fix is needed.

Upstream PR has all test steps and I tested this with rhods 1.32 kserve.

Test instruction: https://github.com/opendatahub-io/caikit-tgis-serving/tree/main/demo/kserve/scripts

export TARGET_OPERATOR=rhods
export CHECK_UWM=false


# Update configmap to use the workaround image
  oc edit cm inferenceservice-config -n redhat-ods-applications
...
  storageInitializer: |-
    {
        "image" : "quay.io/jooholee/storage-initializer@sha256:6b6252e6a1df2a1140be4ab1f8b68b159e448aaf27b8f3212d19daeb44381af4",
...
# restart kserve controller
  oc delete pod -n redhat-ods-applications -l control-plane=kserve-controller-manager --force --grace-period=0
#add annotate to the storage-config secret
  oc annotate secret/storage-config  serving.kserve.io/s3-verifyssl="0" -n kserve-demo
# restart runtime pod
  oc delete pod $RUNTIME_POD --force --grace-period=0

Signed-off-by: jooho <jlee@redhat.com>
@@ -166,6 +166,10 @@ def _download_s3(uri, temp_dir: str):
endpoint_url = os.getenv("AWS_ENDPOINT_URL")
if endpoint_url:
kwargs.update({"endpoint_url": endpoint_url})
verify_ssl = os.getenv("S3_VERIFY_SSL")
if verify_ssl:
verify_ssl = verify_ssl != "0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't use true/false more readable?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how upstream use for this annotation.

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 5ed9bae into red-hat-data-services:rhods-1.34 Oct 6, 2023
3 checks passed
@Jooho Jooho linked an issue Nov 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip Validation for SSL
3 participants