[Php83] Skip add #[\Override] on non-empty method from trait on AddOverrideAttributeToOverriddenMethodsRector

[samsonasik]

The PR:

• Fix interface implementer in AddOverrideAttributeToOverriddenMethodsRector, add override only in case of overiding parent method with contents #6447

cause regression which non-empty method override add #[\Override] attribute, which cause error, see

Fatal error: ApplyAttributeToOverrideMethodFromTrait::bar() has #[\Override] attribute, but no matching parent method exists in /in/O2TdJ on line 16

https://3v4l.org/O2TdJ

this patch try to fix it.

[samsonasik]

Fixed 🎉

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

[TomasVotruba]

👍

[PhilETaylor]

Thanks, I'm out of the office so sorry for my slow feedback, as promised on X I will test this as soon as Im at a desk and can.

[PhilETaylor]

  - Downloading rector/rector (dev-main d1b244b)
  - Downgrading rector/rector (1.2.10 => dev-main d1b244b): Extracting archive

Worked perfectly (i.e did not add Override attributes when not needed, whereas it did at the start of the week)

Thanks for addressing this so quick.

One other PHP 8.4 issue though forked the issue to rectorphp/rector-doctrine#352

[samsonasik]

Thank you @PhilETaylor for verify, the compatible nullable param should be fixed now :)

• [DowngradePhp81] Fix nullable param on DowngradeNewInInitializerRector rector-downgrade-php#245