PHP 8.4 Implicitly marking parameter as nullable is deprecated, the explicit nullable type must be used instead

[PhilETaylor]

PHP Deprecated: Rector\Doctrine\NodeManipulator\ColumnPropertyTypeResolver::__construct(): Implicitly marking parameter $doctrineTypeToScalarType as nullable is deprecated, the explicit nullable type must be used instead in /Users/phil/Sites/example.com/vendor/rector/rector/vendor/rector/rector-doctrine/src/NodeManipulator/ColumnPropertyTypeResolver.php on line 51

Deprecated: Rector\Doctrine\NodeManipulator\ColumnPropertyTypeResolver::__construct(): Implicitly marking parameter $doctrineTypeToScalarType as nullable is deprecated, the explicit nullable type must be used instead in /Users/phil/Sites/example.com/vendor/rector/rector/vendor/rector/rector-doctrine/src/NodeManipulator/ColumnPropertyTypeResolver.php on line 51

[PhilETaylor]

Hmm I think this has already been addressed as the current line 51 in the main branch, is not the same as the line 51 that I have on my mac :)

[samsonasik]

That seems after downgrade, nullable should be added when add null default value. This should be covered on downgrade process to support php 8.4 syntax while downgrade to php 7.4

[samsonasik]

Reproduced at https://getrector.com/demo/876d65e2-7925-4f73-bf92-a208de6dc5ff

on apply rules:

-   DowngradePropertyPromotionRector
-  DowngradeNewInInitializerRector

[samsonasik]

rectorphp/rector-downgrade-php#243

[samsonasik]

Re-open, needs to relook more :)

[samsonasik]

I created new fix for it:

• [DowngradePhp81] Fix nullable param on DowngradeNewInInitializerRector rector-downgrade-php#245