Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoImport] Handle multile @\ with comment before #5275

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

samsonasik
Copy link
Member

@TomasVotruba continue of PR:

this handle multiple @\ with comment before.

class TwoRoutesWithCommentBefore
{
/**
* Testsssssssssss
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this space between comment and @Route removed after change is expected as trimmed on redefined PhpDocTextNode

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit e7e40f1 into main Nov 23, 2023
41 checks passed
@samsonasik samsonasik deleted the handle-multiple-at-slash-with-comment branch November 23, 2023 00:27
@samsonasik
Copy link
Member Author

It seems cause invalid change on nested annotation

1) Rector\Core\Tests\Issues\FqcnAnnotationToAttribute\FqcnAnnotationToAttributeTest::test with data set #0
Failed on fixture file "fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 namespace Rector\Core\Tests\Issues\FqcnAnnotationToAttribute\Fixture;
 
+/**
+ *
+@\Doctrine\ORM\Mapping\Table("user", indexes={
+ ,
+ ,
+})
+*/
 #[\Doctrine\ORM\Mapping\Entity]

on PR #5240 when rebased, I will temporary rollback it.

@samsonasik
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant