-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Php80] Handle FQCN @\ usage on AnnotationToAttributeRector #5240
Conversation
b288e90
to
6b59d41
Compare
e4c3409
to
84dfbd7
Compare
Progress 👍 , after rebase of PR: it now only There was 1 failure:
1) Rector\Core\Tests\Issues\FqcnAnnotationToAttribute\FqcnAnnotationToAttributeTest::test with data set #0
Failed on fixture file "fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
namespace Rector\Core\Tests\Issues\FqcnAnnotationToAttribute\Fixture;
#[\Doctrine\ORM\Mapping\Entity]
-#[\Doctrine\ORM\Mapping\Table('user')]
#[\Doctrine\ORM\Mapping\Index(name: 'name_index', columns: ['name'])]
#[\Doctrine\ORM\Mapping\Index(name: 'surname_index', columns: ['surname'])]
#[\Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity('azureB2cUuid')] that seems due to |
84dfbd7
to
f0afc9d
Compare
@ZZromanZZ Fixed 🎉 |
Wow, thank you 👍 |
#[\Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity('azureB2cUuid')] | ||
#[\Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity('uuid')] | ||
#[\Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity('email')] | ||
#[\Doctrine\ORM\Mapping\Table('user')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this #[\Doctrine\ORM\Mapping\Table('user')]
on the last attribute seems due to doctrine configuration structure, I think it doesn't matter :)
All checks have passed 🎉 @TomasVotruba let's merge it ;) |
Fixes rectorphp/rector#8301