Deprecate TypedPropertyFromStrictConstructorReadonlyClassRector as based on docblock and public elements; use private elements and property promotion instead #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-remove-docblock-readonly-property-rule
branch
from
e554128 to
1481518
Compare
|
this rule is really useful for us. we will port it into our custom rector rule-set |
|
I'd recommend to use |
TomasVotruba
force-pushed
the
tv-remove-docblock-readonly-property-rule
branch
from
1481518 to
8279ffa
Compare
thats the goal in the end. we use |
…xity tree and spot architecture flaws (#5025)
…sed on docblock and public elements; use private elements and property promotion instead
TomasVotruba
force-pushed
the
tv-remove-docblock-readonly-property-rule
branch
from
b43d484 to
30ca9a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking into more complex rules spotted in #5025. It seems this one is going back to the doblock-based logic we try to avoid from. Hence Rector 0.15 blogpost - https://getrector.com/blog/new-in-rector-015-complete-safe-and-known-type-declarations
The Rector upgrade path is based on PHP native features, so the motivation is to rise the PHP version, instead of "backporting" features using markers. Saying that, I'll deprecate this rule and it should be made private, if needed, not to promote docblock based logic.
My appologies this got through my review 🙏
Ref #4552