Deprecate TypedPropertyFromStrictConstructorReadonlyClassRector as ba…

…sed on docblock and public elements; use private elements and property promotion instead
rectorphp · Sep 19, 2023 · 1481518 · 1481518
1 parent e8718df
commit 1481518
Show file tree

Hide file tree

Showing 15 changed files with 15 additions and 364 deletions.
diff --git a/config/set/type-declaration.php b/config/set/type-declaration.php
@@ -35,7 +35,6 @@
 use Rector\TypeDeclaration\Rector\FunctionLike\AddReturnTypeDeclarationFromYieldsRector;
 use Rector\TypeDeclaration\Rector\Param\ParamTypeFromStrictTypedPropertyRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;
-use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorReadonlyClassRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictGetterMethodReturnTypeRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictSetUpRector;
@@ -47,7 +46,6 @@
         TypedPropertyFromAssignsRector::class,
         AddReturnTypeDeclarationBasedOnParentClassMethodRector::class,
         ReturnTypeFromStrictTypedPropertyRector::class,
-        TypedPropertyFromStrictConstructorReadonlyClassRector::class,
         TypedPropertyFromStrictConstructorRector::class,
         ParamTypeFromStrictTypedPropertyRector::class,
         AddVoidReturnTypeWhereNoReturnRector::class,

diff --git a/phpstan.neon b/phpstan.neon
@@ -556,3 +556,9 @@ parameters:
 
         - '#Access to an undefined property (.*?)\\Core\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'
         - '#Property Rector\\Core\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts \(array<PhpParser\\Node\\Stmt>\|null\) does not accept array<PhpParser\\Node\\Stmt\|null>#'
+
+        # deprecation
+        -
+            message: '#Unreachable statement \- code above always terminates#'
+            path: rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorReadonlyClassRector.php
+        - '#Fetching class constant class of deprecated class Rector\\TypeDeclaration\\Rector\\Property\\TypedPropertyFromStrictConstructorReadonlyClassRector#'
diff --git a/...yFromStrictConstructorReadonlyClassRector/Fixture/immutable_class_public_property.php.inc b/...yFromStrictConstructorReadonlyClassRector/Fixture/immutable_class_public_property.php.inc
diff --git a/...onstructorReadonlyClassRector/Fixture/immutable_class_public_property_useless_var.php.inc b/...onstructorReadonlyClassRector/Fixture/immutable_class_public_property_useless_var.php.inc
diff --git a/...PropertyFromStrictConstructorReadonlyClassRector/Fixture/readonly_public_property.php.inc b/...PropertyFromStrictConstructorReadonlyClassRector/Fixture/readonly_public_property.php.inc
diff --git a/...pertyFromStrictConstructorReadonlyClassRector/Fixture/skip_default_false_in_param.php.inc b/...pertyFromStrictConstructorReadonlyClassRector/Fixture/skip_default_false_in_param.php.inc
diff --git a/...r/Property/TypedPropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_doc.php.inc b/...r/Property/TypedPropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_doc.php.inc
diff --git a/...PropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_doctrine_collection.php.inc b/...PropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_doctrine_collection.php.inc
diff --git a/...tyFromStrictConstructorReadonlyClassRector/Fixture/skip_literal_incompatible_type.php.inc b/...tyFromStrictConstructorReadonlyClassRector/Fixture/skip_literal_incompatible_type.php.inc
diff --git a/...PropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_literal_string_type.php.inc b/...PropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_literal_string_type.php.inc
diff --git a/...PropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_non_public_property.php.inc b/...PropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_non_public_property.php.inc
diff --git a/...structorReadonlyClassRector/TypedPropertyFromStrictConstructorReadonlyClassRectorTest.php b/...structorReadonlyClassRector/TypedPropertyFromStrictConstructorReadonlyClassRectorTest.php
diff --git a/...Property/TypedPropertyFromStrictConstructorReadonlyClassRector/config/configured_rule.php b/...Property/TypedPropertyFromStrictConstructorReadonlyClassRector/config/configured_rule.php