[Core] Improve performance: remove unnecessary loop on SimpleCallableNodeTraverser #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
deleted the
improve-performance-remove-unnecessary-loop-on-simple-callable-node-traverser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop over nodes with verify parent Node was introduced on PR:
to handle private method used in FuncCall with ArrowFunction.
This PR try to improve performance by remove the loop, with simplified solution by verify:
passed node variable is a Node
otherwise, it is an array of Nodes, which mostly usage is by pass
$node->stmts, which parent node is the$nodeso no need to loop over to verify.