[DeadCode] Handle RemoveUnusedPrivateMethodRector+RemoveDuplicatedIfReturnRector when private method used in FuncCall with ArrowFunction

[samsonasik]

Given the following code:

final class SkipUsedInArrayMap
{
    public function run(): array
    {
        return array_map(
            static fn (string $bar): string => self::returnFoo(),
            ['bar']
        );
    }

    private static function returnFoo(): string
    {
        return 'foo';
    }
}

It currently remove the private method, which should not, as it used. Applied rules:

Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
Rector\DeadCode\Rector\FunctionLike\RemoveDuplicatedIfReturnRector;

Ref https://getrector.org/demo/66d03737-04b4-4345-89e5-074046ba496c

This PR try to fix it. Fixes rectorphp/rector#7547

[samsonasik]

Fixed 🎉 /cc @alcohol

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[samsonasik]

The issue seems not about array_map(), change to other FuncCall seems still removed.

[samsonasik]

It seems can be resolved by verify node has parent for ParentConnectingVisitor on SimpleCallableNodeTraverser

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[samsonasik]

Ok, I got it, the ArrowFunction when call ->getStmts(), it returns :

return [new Node\Stmt\Return_($this->expr)]

while the Node\Stmt\Return_ itself doesn't has parent Node yet.

It can be correctly handled by check Return_ statement has no parent, while Return_ expr has parent ArrowFunction, so mirror Return_ parent to the ArrowFunction f7125f3

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[TomasVotruba]

Thank you 😊