Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Handle default value on CallableThisArrayToAnonymousFunctionRector #1900

Merged
merged 6 commits into from
Mar 3, 2022
Merged

[CodeQuality] Handle default value on CallableThisArrayToAnonymousFunctionRector #1900

merged 6 commits into from
Mar 3, 2022

Conversation

samsonasik
Copy link
Member

Fixes rectorphp/rector#7040

Tested in both :

  • consume other class
  • consume current $this class.

@samsonasik
Copy link
Member Author

/cc @mkrauser

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

rebased.

@TomasVotruba TomasVotruba merged commit efd8084 into main Mar 3, 2022
@TomasVotruba TomasVotruba deleted the fix-7040 branch March 3, 2022 21:49
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of CallableThisArrayToAnonymousFunctionRector
3 participants
@samsonasik @TomasVotruba @actions-user