phpstan

rectorphp · Mar 3, 2022 · 32ce6f7 · 32ce6f7
1 parent 0b8151e
commit 32ce6f7
Showing 1 changed file with 15 additions and 9 deletions.
diff --git a/rules/Php72/NodeFactory/AnonymousFunctionFactory.php b/rules/Php72/NodeFactory/AnonymousFunctionFactory.php
@@ -325,22 +325,28 @@ private function createParams(PhpMethodReflection $phpMethodReflection, array $p
         $params = [];
         foreach ($parameterReflections as $key => $parameterReflection) {
             $param = new Param(new Variable($parameterReflection->getName()));
+            $this->applyParamType($param, $parameterReflection);
+            $this->applyParamDefaultValue($param, $parameterReflection, $key, $classMethod);
 
-            if (! $parameterReflection->getType() instanceof MixedType) {
-                $param->type = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode(
-                    $parameterReflection->getType(),
-                    TypeKind::PARAM()
-                );
-            }
-
-            $this->applyDefaultValue($param, $parameterReflection, $key, $classMethod);
             $params[] = $param;
         }
 
         return $params;
     }
 
-    private function applyDefaultValue(
+    private function applyParamType(Param $param, ParameterReflection $parameterReflection): void
+    {
+        if ($parameterReflection->getType() instanceof MixedType) {
+            return;
+        }
+
+        $param->type = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode(
+            $parameterReflection->getType(),
+            TypeKind::PARAM()
+        );
+    }
+
+    private function applyParamDefaultValue(
         Param $param,
         ParameterReflection $parameterReflection,
         int $key,