[DeadCode] Handle RemoveUnusedConstructorParamRector + RemoveUnusedPrivatePropertyRector

[samsonasik]

Given the following code:

final class DoNotRemoveParameterInMiddle
{
    private $propertyA;
    private $propertyB;
    private $propertyC;

    public function __construct($propertyA, $propertyB, $propertyC)
    {
        $this->propertyA = $propertyA;
        $this->propertyB = $propertyB;
        $this->propertyC = $propertyC;
    }

    public function run()
    {
        echo $this->propertyA;
        echo $this->propertyC;
    }
}

It currently produce:

 final class DoNotRemoveParameterInMiddle
 {
     private $propertyA;
-    private $propertyB;
     private $propertyC;
 
-    public function __construct($propertyA, $propertyB, $propertyC)
+    public function __construct($propertyA, $propertyC)
     {
         $this->propertyA = $propertyA;
-        $this->propertyB = $propertyB;
         $this->propertyC = $propertyC;
     }

which middle parameter is removed, and cause a BC break. The middle parameter should not be deleted.

Applied rules:

Rector\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector;
Rector\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector;

[samsonasik]

Fixed 🎉

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

Thank you 👍