[Rector] Update to rector 0.12.15, apply parallel, and RemoveUnusedPrivatePropertyRector

[samsonasik]

Q	A
QA?	✔️

• updated rector dependency to 0.12.15
• apply parallel process to speed up check
• apply RemoveUnusedPrivatePropertyRector
• Enable allow-plugins for composer 2.2 support.

[samsonasik]

All green 🎉

[samsonasik]

updated to use rector 0.12.14 and re-run rector so option skip for RemoveUnusedPrivatePropertyRector now cleaned up.

[samsonasik]

only remove property and its assignment in constructor for unused private property without removing its middle __construct parameter that fill it to avoid BC break.

[samsonasik]

All green 🎉

[butschster]

Hi @samsonasik! Thank you very much! You are the best! We are going to start working on spiral framework 3.0 and it would be great to prepare rector for php 8.0!

[samsonasik]

@butschster yes 👍 , just let me know there is a branch 3.0 to give php 8.0 rector rules to apply

[samsonasik]

updated to use rector 0.12.15

[samsonasik]

Close-Reopen to restart build

[samsonasik]

All green 🎉

[butschster]

@butschster yes 👍 , just let me know there is a branch 3.0 to give php 8.0 rector rules to apply

I think, you can start from 2.9 branch

[samsonasik]

2.9 branch still using php >=7.2:

framework/composer.json

Line 21 in 3dca645

"php": ">=7.2",

is it needs to be updated to >=8.0? For safer in the future, I think it is better to use:

"php": "~8.0.0 || ~8.1.0"

since php is not semver.

[butschster]

2.9 branch still using php >=7.2:

framework/composer.json

Line 21 in 3dca645

"php": ">=7.2",

is it needs to be updated to >=8.0? For safer in the future, I think it is better to use:

"php": "~8.0.0 || ~8.1.0"

since php is not semver.