module #2 (debakor) #30
Open
+505
−486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // food add function | ||
| const addNewFood = () => { | ||
| let newFood = getRandomCell(); | ||
| while (isSnake(newFood) || isFood(newFood)) { |
There was a problem hiding this comment.
an object can be put to a cell only if it isn't occupied yet.
why not create a reusable function like
const isOccupied = (cell) => isSnake(cell) || isFood(cell) || isPoison(cell);
| newPoison = getRandomCell(); | ||
| } | ||
| setPoisons((currentPoison) => [...currentPoison, newPoison]); | ||
| }; |
There was a problem hiding this comment.
addFoods and addPoison, removeFood and removePoison works the same, you can merge them to have one addObject function, and one removeObject function.
| const isFood = ({ x, y }) => | ||
| foods.some((food) => food?.x === x && food?.y === y); | ||
|
|
||
| const isPoison = ({ x, y }) => |
There was a problem hiding this comment.
you can also wrap these functions into a useCallback hook so that they don't get instantiated again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.