Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final edits before release of 0.7.0 #1500

Merged
merged 9 commits into from
Sep 10, 2021
Merged

Final edits before release of 0.7.0 #1500

merged 9 commits into from
Sep 10, 2021

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Aug 17, 2021

Description

Added a few lines in the README to inform about the renaming of the folders.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, are you planning to add in this one the new version in the init?

@miguelgfierro
Copy link
Collaborator

codecov went bananas XDDD

@codecov-commenter
Copy link

Codecov Report

Merging #1500 (1cab0e2) into staging (a8c81fe) will decrease coverage by 12.20%.
The diff coverage is 82.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##           staging    #1500       +/-   ##
============================================
- Coverage    74.23%   62.03%   -12.21%     
============================================
  Files           84       84               
  Lines         8369     8397       +28     
============================================
- Hits          6213     5209     -1004     
- Misses        2156     3188     +1032     
Impacted Files Coverage Δ
recommenders/evaluation/spark_evaluation.py 86.66% <81.48%> (-0.78%) ⬇️
recommenders/utils/constants.py 100.00% <100.00%> (ø)
...ecommenders/models/newsrec/io/mind_all_iterator.py 12.21% <0.00%> (-86.65%) ⬇️
recommenders/models/newsrec/io/mind_iterator.py 15.67% <0.00%> (-82.71%) ⬇️
...ommenders/models/deeprec/io/sequential_iterator.py 15.85% <0.00%> (-81.94%) ⬇️
recommenders/models/newsrec/models/base_model.py 30.90% <0.00%> (-59.40%) ⬇️
...deeprec/models/sequential/sequential_base_model.py 46.97% <0.00%> (-47.66%) ⬇️
recommenders/models/geoimc/geoimc_data.py 41.66% <0.00%> (-44.80%) ⬇️
...enders/models/deeprec/io/dkn_item2item_iterator.py 45.61% <0.00%> (-42.11%) ⬇️
...menders/models/deeprec/models/graphrec/lightgcn.py 51.47% <0.00%> (-40.24%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c806d55...1cab0e2. Read the comment docs.

@miguelgfierro
Copy link
Collaborator

miguelgfierro commented Sep 9, 2021

@anargyri we got a max time error in the test of notebook spark, I increased the time

@miguelgfierro miguelgfierro mentioned this pull request Sep 9, 2021
3 tasks
@anargyri
Copy link
Collaborator Author

looks good, are you planning to add in this one the new version in the init?

Sorry, I just changed it.

@anargyri
Copy link
Collaborator Author

@anargyri we got a max time error in the test of notebook spark, I increased the time

Thanks. Is this related to the recurring failure we see in the build pipelines with ALS fit()? It frequently fails here.
It looks like a Java connection error when calling the ALS fit() method.

@anargyri
Copy link
Collaborator Author

anargyri commented Sep 10, 2021

Now the build fails to see the GPU:

=================================== FAILURES ===================================
_________________________________ test_gpu_vm __________________________________

    @pytest.mark.notebooks
    @pytest.mark.gpu
    def test_gpu_vm():
>       assert get_number_gpus() >= 1
E       assert 0 >= 1
E        +  where 0 = get_number_gpus()

tests/unit/examples/test_notebooks_gpu.py:18: AssertionError

@anargyri anargyri changed the title Andreas/edits Final edits before release of 0.7.0 Sep 10, 2021
@miguelgfierro
Copy link
Collaborator

Now the build fails to see the GPU:

I think this one also went bananas, maybe when @laserprec comes he can review. I think this one is ok to merge

@miguelgfierro miguelgfierro merged commit 966353c into staging Sep 10, 2021
@miguelgfierro miguelgfierro deleted the andreas/edits branch September 10, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants