Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to main to merge diversity metrics and update the folder names #1480

Merged
merged 133 commits into from
Aug 23, 2021

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@loomlike
Copy link
Collaborator

curious why we are still using master branch?

Actually the merging is into main. Only the title says master (typo). FYI I checked master branch hasn't been used after we deprecated it so I just removed it @miguelgfierro.

@loomlike loomlike closed this Aug 15, 2021
@loomlike loomlike changed the title Staging to master to merge diversity metrics and update the folder names Staging to main to merge diversity metrics and update the folder names Aug 15, 2021
@loomlike
Copy link
Collaborator

Accidentally closed the PR. reopening it lol

@loomlike loomlike reopened this Aug 15, 2021
Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anargyri
Copy link
Collaborator

Since this merge includes the renaming of the folders, I suggest we add a note about this on the front page. Also, how about tagging this as a release?

@miguelgfierro
Copy link
Collaborator Author

Also, how about tagging this as a release?

agree

@laserprec with the changes you are making to the build pipeline, is it ok to merge this PR?

@anargyri
Copy link
Collaborator

Also, how about tagging this as a release?

agree

@laserprec with the changes you are making to the build pipeline, is it ok to merge this PR?

I have prepared PR #1500 about this, you could edit as you like and merge into staging.

@laserprec
Copy link
Contributor

@miguelgfierro Yup! These build changes are standalone, and there weren't any source code changes introduced. One thing it may change is that PR-ing into main and staging will trigger this new PR-Gate in GitHub Actions to run in addition to our existing CIs in ADO.

All of the GitHub Actions are non-blocking until we this new CI infra achieve feature-parity with out existing ADO CIs.

@miguelgfierro
Copy link
Collaborator Author

I'll merge this then

@miguelgfierro miguelgfierro merged commit 98d661e into main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants