Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Doc]Error on recorded event query. #132

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

EwanC
Copy link
Collaborator

@EwanC EwanC commented Apr 10, 2023

Specify that it is an error to query an event returned by a queue recording for either its command status or profiling info. Addresses feedback intel#5626 (comment)

Additionally:

  • The description on the meaning of event command status for a graph submission is moved next to the description of graph submission shortcuts. Where there is a returned event that this behaviour applies to.
  • Rephrased error wording around queue::wait() as "waiting on a queue" to cover queue::wait_and_throw() as well.

Specify that it is an error to query an event returned by
a queue recording for either its command status or profiling info.

Addresses feedback
intel#5626 (comment)

Additionally, the description on the meaning of command status for
a graph submissions is moved next to the description of graph
submission shortcuts.
@EwanC EwanC added the Graph Specification Extension Specification related label Apr 10, 2023
@EwanC EwanC requested review from reble, Bensuo and julianmi April 10, 2023 09:07
@EwanC EwanC changed the title Error on recorded event query. [SYCL][Doc]Error on recorded event query. Apr 10, 2023
Copy link
Collaborator

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@julianmi julianmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@reble reble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graph Specification Extension Specification related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants