Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement error handling for invalid event/queue usage #97

Closed
EwanC opened this issue Mar 13, 2023 · 1 comment · Fixed by #250
Closed

Implement error handling for invalid event/queue usage #97

EwanC opened this issue Mar 13, 2023 · 1 comment · Fixed by #250
Labels
enhancement New feature or request Graph Implementation Related to DPC++ implementation and testing

Comments

@EwanC
Copy link
Collaborator

EwanC commented Mar 13, 2023

Implement the erroneous wait behaviour defined by #78

This includes:

  • Throwing an error on handler::depends_on() when an event is passed that doesn't correspond to a node (related to Implement creating an edge with handler::depends_on() #89)
  • Throwing an error when waiting on an event returned from a queue submission recorded to a graph.
  • calling queue::wait() on a queue in the recording state
@EwanC EwanC added enhancement New feature or request Graph Implementation Related to DPC++ implementation and testing labels Mar 13, 2023
@EwanC
Copy link
Collaborator Author

EwanC commented Apr 12, 2023

Should also include the changes from #132 that specify an error on quering an event returned fro queue recording for profiling info or command status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant