Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement creating an edge with handler::depends_on() #89

Closed
EwanC opened this issue Mar 13, 2023 · 1 comment · Fixed by #170
Closed

Implement creating an edge with handler::depends_on() #89

EwanC opened this issue Mar 13, 2023 · 1 comment · Fixed by #170
Assignees
@EwanC
Labels
Graph Implementation Related to DPC++ implementation and testing

Comments

@EwanC
Copy link
Collaborator

EwanC commented Mar 13, 2023

Our specification defines that when using handler::depends_on() during node creation, passing an event returned from queue recording, will create a node edge.

This functionality needs to be implemented in the prototype and tests added to https://github.com/Bensuo/llvm-test-suite/tree/intel/SYCL/CommandGraph

Currently handler::depends_on is causing segfaults when using record & replay graph creation with oneDNN
@EwanC EwanC added the Graph Implementation Related to DPC++ implementation and testing label Mar 13, 2023
@EwanC EwanC mentioned this issue Mar 13, 2023
Closed
@EwanC EwanC mentioned this issue Mar 30, 2023
Merged
@Bensuo
Copy link
Collaborator

Bensuo commented Mar 30, 2023

Partially implemented in #100 for the record and replay API only.

@EwanC EwanC self-assigned this May 10, 2023
@EwanC EwanC mentioned this issue May 10, 2023
Merged
EwanC added a commit that referenced this issue May 15, 2023
@EwanC
[SYCL][Graph] Create handler::depends_on edges in Explicit API
7da187a 
An event returned from a queue submission captured by
Record & Replay should be able to create an edge to
a node created by the Explicit API.

This edge is defined by passing the event to
`handler::depends_on` inside the command-group added
explicitly to the graph.

Closes #89
EwanC added a commit that referenced this issue May 15, 2023
@EwanC
[SYCL][Graph] Create handler::depends_on edges in Explicit API
316c3a3 
An event returned from a queue submission captured by Record & Replay should be able to create an edge to a node created by the Explicit API.

This edge is defined by passing the event to `handler::depends_on` inside the command-group added explicitly to the graph.

Closes #89
EwanC added a commit that referenced this issue May 15, 2023
@EwanC
[SYCL][Graph] Create handler::depends_on edges in Explicit API
5106eb1 
An event returned from a queue submission captured by Record & Replay should be able to create an edge to a node created by the Explicit API.

This edge is defined by passing the event to `handler::depends_on` inside the command-group added explicitly to the graph.

Closes #89
EwanC pushed a commit that referenced this issue Jan 3, 2024
@oltolm
[lldb] add support for thread names on Windows (#74731)
95e5839 
This PR adds support for thread names in lldb on Windows.

```
(lldb) thr list
Process 2960 stopped
  thread #53: tid = 0x03a0, 0x00007ff84582db34 ntdll.dll`NtWaitForMultipleObjects + 20
  thread #29: tid = 0x04ec, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'SPUW.6'
  thread #89: tid = 0x057c, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'PPU[0x1000019] physics[main]'
  thread #3: tid = 0x0648, 0x00007ff843c2cafe combase.dll`InternalDoATClassCreate + 39518
  thread #93: tid = 0x0688, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'PPU[0x100501d] uMovie::StreamingThread'
  thread #1: tid = 0x087c, 0x00007ff842e7a104 win32u.dll`NtUserMsgWaitForMultipleObjectsEx + 20
  thread #96: tid = 0x0890, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'PPU[0x1002020] HLE Video Decoder'
<...>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EwanC EwanC

Labels
Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SYCL][Graph] Create handler::depends_on edges in Explicit API reble/llvm
2 participants
@EwanC @Bensuo