Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ff/hermes ci build #3980

Merged
merged 17 commits into from
Oct 5, 2021
Merged

Ff/hermes ci build #3980

merged 17 commits into from
Oct 5, 2021

Conversation

fronck
Copy link

@fronck fronck commented Sep 23, 2021

What, How & Why?

Partial fix for #3993:

  • Fixed build failures on build on Jenkins.
  • Still outstanding: fix build errors on test step on Jenkins.

@fronck fronck changed the base branch from kh/hermes-on-android to ms/hermes September 23, 2021 10:24
@fronck fronck force-pushed the ff/hermes-ci-build branch from 7ac721c to 65c3395 Compare October 4, 2021 10:30
@fronck fronck requested a review from kraenhansen October 5, 2021 08:59
@fronck fronck marked this pull request as ready for review October 5, 2021 08:59
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable :)

@fronck fronck merged commit c6289c5 into ms/hermes Oct 5, 2021
@fronck fronck deleted the ff/hermes-ci-build branch October 5, 2021 09:55
kraenhansen pushed a commit that referenced this pull request Nov 16, 2021
Fixed RN build issues on `build` step on Jenkins.
kraenhansen pushed a commit that referenced this pull request Nov 19, 2021
Fixed RN build issues on `build` step on Jenkins.
kraenhansen pushed a commit that referenced this pull request Nov 22, 2021
Fixed RN build issues on `build` step on Jenkins.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants