Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes redundant_void_return rule autocorrect when preprocessor macros are present. #2116

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Conversation

jszumski
Copy link
Contributor

Fixes #2115. Very similar to #2105

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.46s vs 0.6s on master (23% faster)
📖 Linting Alamofire with this PR took 3.69s vs 5.82s on master (36% faster)
📖 Linting Firefox with this PR took 15.57s vs 17.72s on master (12% faster)
📖 Linting Kickstarter with this PR took 26.13s vs 25.55s on master (2% slower)
📖 Linting Moya with this PR took 2.29s vs 2.83s on master (19% faster)
📖 Linting Nimble with this PR took 2.21s vs 3.14s on master (29% faster)
📖 Linting Quick with this PR took 0.66s vs 1.06s on master (37% faster)
📖 Linting Realm with this PR took 4.29s vs 4.71s on master (8% faster)
📖 Linting SourceKitten with this PR took 1.4s vs 1.61s on master (13% faster)
📖 Linting Sourcery with this PR took 5.99s vs 6.15s on master (2% faster)
📖 Linting Swift with this PR took 21.74s vs 21.09s on master (3% slower)
📖 Linting WordPress with this PR took 22.9s vs 23.41s on master (2% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #2116 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2116      +/-   ##
=========================================
+ Coverage    89.9%   89.9%   +<.01%     
=========================================
  Files         266     266              
  Lines       15370   15372       +2     
  Branches     1013    1012       -1     
=========================================
+ Hits        13818   13820       +2     
  Misses       1532    1532              
  Partials       20      20
Impacted Files Coverage Δ
.../SwiftLintFramework/Rules/ClosureSpacingRule.swift 100% <100%> (ø) ⬆️
...tLintFramework/Rules/RedundantVoidReturnRule.swift 94.91% <100%> (ø) ⬆️
Source/SwiftLintFramework/Models/Command.swift 97.82% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0982045...28989be. Read the comment docs.

Copy link
Collaborator

@marcelofabri marcelofabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marcelofabri marcelofabri merged commit 2b9804c into realm:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants