Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colon autocorrect when preprocessor macros are present #2105

Merged
merged 1 commit into from
Mar 18, 2018
Merged

Fix colon autocorrect when preprocessor macros are present #2105

merged 1 commit into from
Mar 18, 2018

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2099

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.42s vs 0.39s on master (7% slower)
📖 Linting Alamofire with this PR took 3.42s vs 3.37s on master (1% slower)
📖 Linting Firefox with this PR took 13.46s vs 13.37s on master (0% slower)
📖 Linting Kickstarter with this PR took 20.79s vs 20.82s on master (0% faster)
📖 Linting Moya with this PR took 1.96s vs 1.96s on master (0% slower)
📖 Linting Nimble with this PR took 1.91s vs 1.91s on master (0% slower)
📖 Linting Quick with this PR took 0.58s vs 0.56s on master (3% slower)
📖 Linting Realm with this PR took 3.73s vs 3.79s on master (1% faster)
📖 Linting SourceKitten with this PR took 1.19s vs 1.17s on master (1% slower)
📖 Linting Sourcery with this PR took 5.0s vs 5.06s on master (1% faster)
📖 Linting Swift with this PR took 14.41s vs 14.59s on master (1% faster)
📖 Linting WordPress with this PR took 16.57s vs 16.79s on master (1% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #2105 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
- Coverage   89.74%   89.73%   -0.02%     
==========================================
  Files         262      262              
  Lines       15117    15117              
  Branches      981      983       +2     
==========================================
- Hits        13567    13565       -2     
- Misses       1532     1534       +2     
  Partials       18       18
Impacted Files Coverage Δ
Source/SwiftLintFramework/Rules/ColonRule.swift 95% <ø> (ø) ⬆️
...wiftLintFramework/Rules/ColonRule+Dictionary.swift 90.32% <100%> (ø) ⬆️
Source/SwiftLintFramework/Models/Command.swift 95.65% <0%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fca6fd0...8e3b929. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants