Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] fix(sandpack): do not translate code blocks #4034

Merged
merged 1 commit into from
Nov 3, 2021
Merged

[beta] fix(sandpack): do not translate code blocks #4034

merged 1 commit into from
Nov 3, 2021

Conversation

danilowoz
Copy link
Contributor

Sandpack has introduced a new HTML attribute to avoid Google Translate translating the code editor and the preview layer, but still translating the action buttons.

Solve #3977

Screenshot 2021-11-03 at 11 34 17
Screenshot 2021-11-03 at 11 34 25

@facebook-github-bot
Copy link
Collaborator

Hi @danilowoz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon merged commit 9707812 into reactjs:main Nov 3, 2021
@gaearon
Copy link
Member

gaearon commented Nov 3, 2021

thanks!

@danilowoz danilowoz deleted the fix/sandpack-translate branch November 4, 2021 09:00
@gaearon gaearon added the beta label Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants