Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Google translate breaks Sandboxes by translating their contents #3977

Closed
rachelnabors opened this issue Oct 22, 2021 · 4 comments
Closed

Comments

@rachelnabors
Copy link
Contributor

When I use Google Translate to translate a page, it translates the source code and error messages in the sandboxes. Could we make it so the code in the sandbox and the code in the error messages are not translated?

Screenshot 2021-10-22 at 15 14 15

@shrirambalaji
Copy link
Contributor

shrirambalaji commented Oct 23, 2021

@rachelnabors Taking a dig at this.

image

We probably also want to avoid translation of all code blocks too right?

Also, the translation should only be disabled for the content and the preview. the buttons should still be translated, kinda like this or do we not want that too?

image

@rachelnabors
Copy link
Contributor Author

Good catch on the code blocks!

  • All code inside Sandboxes, Code Blocks, and inline code should not be translated.
  • Sandbox UI should be translated
  • Sandbox Error messages should be translated, but not the code (this is something CodeSandbox might be better able to fix)

@shrirambalaji
Copy link
Contributor

Yeah sandpack has those abstracted so they need to handle translation of error messages in there.

@gaearon
Copy link
Member

gaearon commented Nov 4, 2021

Should be fixed.

@gaearon gaearon closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants