-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home page examples hooks and classes #2838
Conversation
Hi @Zeko369! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Deploy preview for reactjs ready! Built with commit 78605e9 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
The second example ( Any ideas/comments? |
a welcomed change that will probably require the approval of managers because it involves the frontpage of the website. Thank you for this pull request and i hope it will bring things forward! |
@gaearon Are you rewriting all the examples using hooks and functional components? I'd like to help if that's the case :) The tutorial, with classes, is a bit intimidating |
i just updated hooks section for useState in functional component if anyone is maintainer here they can merge/review my pull request here 👉#2842 |
Upgrade Flow version and add a tab switcher to switch between hooks and class examples on homepage
Closes: #2833