Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactjs.org homepage examples are outdated #2833

Closed
slk333 opened this issue Mar 14, 2020 · 2 comments
Closed

reactjs.org homepage examples are outdated #2833

slk333 opened this issue Mar 14, 2020 · 2 comments

Comments

@slk333
Copy link

slk333 commented Mar 14, 2020

The examples are located here:
https://github.com/reactjs/reactjs.org/tree/master/content/home/examples
We can see that they received little to no change since their creation, more than 3 years ago.

There are two problems:

  • The examples don't use hooks
  • The examples use classes

More generally, reactjs.org introduction largely ignores hooks, while using classes throughout. As a result, hooks are largely ignored by newcomers.

Suggestion: the Clock example and the Markdown Editor examples should come in two alternative versions: one using Class, one using function components and useState() and useEffect() hooks.

@Zeko369
Copy link
Contributor

Zeko369 commented Mar 15, 2020

I'm already working on this, will have a PR today

@slk333
Copy link
Author

slk333 commented Apr 6, 2020

#2874 (comment)

@slk333 slk333 closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants