Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tightened up getSnapshotBeforeUpdate to better handle falsy snapshot values. #12

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Tightened up getSnapshotBeforeUpdate to better handle falsy snapshot values. #12

merged 1 commit into from
Apr 3, 2018

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 3, 2018

No description provided.

@bvaughn bvaughn requested a review from flarnie April 3, 2018 17:40
flarnie
flarnie approved these changes Apr 3, 2018
View reviewed changes
Copy link

@flarnie flarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! My only request was a test - and then saw you did write one already. :)

double_lizard_ship-it

@bvaughn bvaughn mentioned this pull request Apr 3, 2018
Merged
@bvaughn
Copy link
Contributor Author

bvaughn commented Apr 3, 2018

Your GIFs are amazing.

@bvaughn bvaughn merged commit 6f81537 into master Apr 3, 2018
@bvaughn bvaughn deleted the getSnapshotBeforeUpdate-falsy-values branch April 3, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flarnie flarnie flarnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvaughn @flarnie