Use named "polyfill" export and support ES module target #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
changed the title
Andarist
approved these changes
Apr 3, 2018
There was a problem hiding this comment.
LGTM, it's a bummer that we can't use default export for this, but I don't think it's possible to work around this.
Or rather - it's possible to keep default export, but it would mean forcing .default on CJS consumers. Either way not super friendly for CJS consumers so 🤷♂️
bvaughn
changed the title
|
Friendly ping 😄 |
gaearon
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support ES modules in version 2.0, this PR replaces the default export with a named "polyfill" export (and re-enabled ES module target).
Related docs update PR: reactjs/react.dev/pull/764
Resolves #8