Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: add vs2022 update command to bump ci to vs2022 pre 5 #796

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

dpvreony
Copy link
Member

What kind of change does this PR introduce?
CI fix where MAUI requires later version of vs2022

What is the current behavior?
ci failing due to requiring 17.0.0-pre.5.0 for maui

What is the new behavior?
ci not to fail

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

ci failing due to requiring 17.0.0-pre.5.0 for maui
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #796 (f57726d) into main (e308ca9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #796   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files          99       99           
  Lines        4968     4968           
=======================================
  Hits         3696     3696           
  Misses       1272     1272           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b331cf6...f57726d. Read the comment docs.

@glennawatson glennawatson merged commit cdf6f35 into main Oct 21, 2021
@glennawatson glennawatson deleted the fix-ci-vs2022p5 branch October 21, 2021 21:50
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants