Skip to content

Commit

Permalink
Fixes #787 About unnecessary ItemGroup with condition in Splat.csproj (
Browse files Browse the repository at this point in the history
…#788)

* Fixes #787
Remove ItemGroup that has conditon with TFM that starts with `net46`in Splat.csproj file. 
Having this condition of TFM net46* is unnecessary, Because defined TargetFrameworks does not contain NET Fx related TFM.

* remove the net46 and net472 as well because these TFMs are in the Splat.Drawing as suggested in issue comment:
 #787 (comment)
  • Loading branch information
eriawan authored Oct 8, 2021
1 parent 5fe819c commit e308ca9
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/Splat/Splat.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>netstandard2.0;net5.0;net6.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net461;net472</TargetFrameworks>
<AssemblyName>Splat</AssemblyName>
<RootNamespace>Splat</RootNamespace>
<Authors>.NET Foundation and Contributors</Authors>
Expand All @@ -11,8 +10,5 @@
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup Condition=" $(TargetFramework.StartsWith('net46')) ">
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>

</Project>

0 comments on commit e308ca9

Please sign in to comment.