Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump Microsoft.AppCenter.Analytics from 4.3.0 to 4.4.0 in /src #773

Merged
merged 11 commits into from
Oct 4, 2021
Merged

build(deps): bump Microsoft.AppCenter.Analytics from 4.3.0 to 4.4.0 in /src #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
35d67fd
build(deps): bump Microsoft.AppCenter.Analytics in /src
dependabot[bot] Sep 24, 2021
d7f8e0d
make target frameworks platform specific
dpvreony Sep 25, 2021
d392ca6
adjust target frameworks
dpvreony Sep 30, 2021
52f8b79
windows target for net6
dpvreony Sep 30, 2021
e57bfdc
adjust tests project restore targets
dpvreony Sep 30, 2021
6d1255d
remove uap for appcenter for now
dpvreony Sep 30, 2021
97b1f70
autofac tests target windows for net5 and 6
dpvreony Sep 30, 2021
9594004
Merge branch 'main' into dependabot/nuget/src/Microsoft.AppCenter.Ana…
dpvreony Sep 30, 2021
838fd25
remove android and ios for now
dpvreony Sep 30, 2021
f16d868
Merge branch 'main' into dependabot/nuget/src/Microsoft.AppCenter.Ana…
dpvreony Oct 1, 2021
e54cc82
Merge branch 'main' into dependabot/nuget/src/Microsoft.AppCenter.Ana…
glennawatson Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Splat.AppCenter/Splat.AppCenter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net5.0;net6.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net5.0-windows10.0.17763.0;net6.0-windows10.0.17763.0</TargetFrameworks>
Copy link
Member

@ChrisPulman ChrisPulman Sep 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe should be 10.0.16299 minimum

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd agree but appcenter targets 17763 :). down to 1 test failure. sorting a vm with vs2022 on it so i can stop throwing things at the build server

<!--need to consider? monoandroid50;xamarin.ios10,uap10.0 -->
<AssemblyName>Splat.AppCenter</AssemblyName>
<RootNamespace>Splat</RootNamespace>
<Authors>.NET Foundation and Contributors</Authors>
Expand All @@ -12,8 +13,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="4.3.0" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="4.3.0" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="4.4.0" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="4.4.0" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Splat.Autofac.Tests/Splat.Autofac.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net5.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net5.0-windows10.0.17763.0;net6.0-windows10.0.17763.0;netcoreapp3.1</TargetFrameworks>

<IsPackable>false</IsPackable>
<NoWarn>$(NoWarn);1591;CA1707;SA1633;CA2000</NoWarn>
Expand Down
4 changes: 2 additions & 2 deletions src/Splat.Tests/Splat.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="MSBuild.Sdk.Extras">
<Project Sdk="MSBuild.Sdk.Extras">

<PropertyGroup>
<TargetFrameworks>net5.0;net6.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net5.0-windows10.0.17763.0;net6.0-windows10.0.17763.0;netcoreapp3.1</TargetFrameworks>
<NoWarn>$(NoWarn);1591;CA1707;SA1633;CA2000;CA1034</NoWarn>
<LangVersion>latest</LangVersion>
<LangVersion>latest</LangVersion>
Expand Down