Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump Microsoft.AppCenter.Analytics from 4.3.0 to 4.4.0 in /src #773

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 22, 2021

Bumps Microsoft.AppCenter.Analytics from 4.3.0 to 4.4.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Sep 22, 2021
@dependabot dependabot bot force-pushed the dependabot/nuget/src/Microsoft.AppCenter.Analytics-4.4.0 branch 3 times, most recently from b4fb326 to 2f180f4 Compare September 24, 2021 20:38
Bumps Microsoft.AppCenter.Analytics from 4.3.0 to 4.4.0.

---
updated-dependencies:
- dependency-name: Microsoft.AppCenter.Analytics
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/src/Microsoft.AppCenter.Analytics-4.4.0 branch from 2f180f4 to 35d67fd Compare September 24, 2021 22:21
ChrisPulman
ChrisPulman previously approved these changes Sep 24, 2021
@ChrisPulman ChrisPulman enabled auto-merge (squash) September 24, 2021 22:24
CI failing due to targeting net5.0, net6.0
@dpvreony
Copy link
Member

had a quick look into the targeting issue. will unpick the test parts later


<PropertyGroup>
<TargetFrameworks>netstandard2.0;net5.0;net6.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net5.0-windows10.0.17763.0;net6.0-windows10.0.17763.0</TargetFrameworks>
Copy link
Member

@ChrisPulman ChrisPulman Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe should be 10.0.16299 minimum

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd agree but appcenter targets 17763 :). down to 1 test failure. sorting a vm with vs2022 on it so i can stop throwing things at the build server

@ChrisPulman ChrisPulman dismissed their stale review September 30, 2021 19:28

Code changes made

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #773 (f16d868) into main (6d71493) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head f16d868 differs from pull request most recent head e54cc82. Consider uploading reports for the commit e54cc82 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   74.39%   74.29%   -0.11%     
==========================================
  Files          99       99              
  Lines        4968     4968              
==========================================
- Hits         3696     3691       -5     
- Misses       1272     1277       +5     
Impacted Files Coverage Δ
src/Splat/Logging/WrappingPrefixLogger.cs 64.70% <0.00%> (-5.89%) ⬇️
...ceMonitoring/DefaultFeatureUsageTrackingSession.cs 68.00% <0.00%> (-4.00%) ⬇️
src/Splat/Logging/WrappingFullLogger.cs 64.28% <0.00%> (-1.30%) ⬇️
src/Splat/Logging/FullLoggerExtensions.cs 27.61% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572aba4...e54cc82. Read the comment docs.

@glennawatson glennawatson enabled auto-merge (squash) October 4, 2021 06:14
@glennawatson glennawatson merged commit 5fe819c into main Oct 4, 2021
@glennawatson glennawatson deleted the dependabot/nuget/src/Microsoft.AppCenter.Analytics-4.4.0 branch October 4, 2021 06:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking change dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants