#669 throw not supported instead of not implemented

reactiveui · Mar 2, 2021 · b29cf40 · b29cf40
1 parent 848a094
commit b29cf40
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/Splat.Prism.Tests/DependencyResolverTests.cs b/src/Splat.Prism.Tests/DependencyResolverTests.cs
@@ -25,7 +25,7 @@ public class DependencyResolverTests
         public void CreateScope_Throws_NotImplementedException()
         {
             using var container = new SplatContainerExtension();
-            Assert.Throws<NotImplementedException>(() => container.CreateScope());
+            Assert.Throws<NotSupportedException>(() => container.CreateScope());
         }
 
         /// <summary>
@@ -35,7 +35,7 @@ public void CreateScope_Throws_NotImplementedException()
         public void RegisterScoped_Throws_NotImplementedException()
         {
             using var container = new SplatContainerExtension();
-            Assert.Throws<NotImplementedException>(() => container.RegisterScoped(
+            Assert.Throws<NotSupportedException>(() => container.RegisterScoped(
                 typeof(IViewFor<ViewModelOne>),
                 () => new ViewOne()));
         }
@@ -47,7 +47,7 @@ public void RegisterScoped_Throws_NotImplementedException()
         public void RegisterManySingleton_Throws_NotImplementedException()
         {
             using var container = new SplatContainerExtension();
-            Assert.Throws<NotImplementedException>(() => container.RegisterManySingleton(
+            Assert.Throws<NotSupportedException>(() => container.RegisterManySingleton(
                 typeof(IViewFor<ViewModelOne>),
                 typeof(ViewOne)));
         }

diff --git a/src/Splat.Prism/SplatContainerExtension.cs b/src/Splat.Prism/SplatContainerExtension.cs
@@ -43,7 +43,7 @@ public SplatContainerExtension()
         /// <inheritdoc/>
         public IScopedProvider CreateScope()
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         /// <inheritdoc/>
@@ -61,7 +61,7 @@ public void FinalizeExtension()
         /// <inheritdoc/>
         public IContainerRegistry RegisterScoped(Type type, Func<IContainerProvider, object> factoryMethod)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         /// <inheritdoc/>
@@ -79,7 +79,7 @@ public bool IsRegistered(Type type, string name)
         /// <inheritdoc/>
         public IContainerRegistry RegisterManySingleton(Type type, params Type[] serviceTypes)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         /// <inheritdoc/>
@@ -140,13 +140,13 @@ public IContainerRegistry RegisterMany(Type type, params Type[] serviceTypes)
         /// <inheritdoc/>
         public IContainerRegistry RegisterScoped(Type @from, Type to)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         /// <inheritdoc/>
         public IContainerRegistry RegisterScoped(Type type, Func<object> factoryMethod)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         /// <summary>
@@ -226,13 +226,13 @@ public IContainerRegistry RegisterSingleton(Type from, Type to, string name)
         /// <inheritdoc/>
         public IContainerRegistry RegisterSingleton(Type type, Func<object> factoryMethod)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         /// <inheritdoc/>
         public IContainerRegistry RegisterSingleton(Type type, Func<IContainerProvider, object> factoryMethod)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         /// <inheritdoc/>