-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Housekeeping: Update Prism to V8 #669
Conversation
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 71.84% 71.83% -0.02%
==========================================
Files 99 99
Lines 4717 4732 +15
==========================================
+ Hits 3389 3399 +10
- Misses 1328 1333 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but probably worth throwing NotSupportedException
instead of NIE
if we aren't supporting scopes?
ok will make adjustment |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Package update
What is the current behavior?
Blocks people wanting to use V8 with Splat
What is the new behavior?
Updates the Splat Prism integration for the new interfaces. Still not supporting scoped objects
What might this PR break?
anyone downstream dependent on v7 but in terms of splat not much, interface was extended not broken
Please check if the PR fulfills these requirements
Other information: