Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Housekeeping: Update Prism to V8 #669

Merged
merged 7 commits into from
Mar 6, 2021
Merged

WIP: Housekeeping: Update Prism to V8 #669

merged 7 commits into from
Mar 6, 2021

Conversation

dpvreony
Copy link
Member

What kind of change does this PR introduce?
Package update

What is the current behavior?
Blocks people wanting to use V8 with Splat

What is the new behavior?
Updates the Splat Prism integration for the new interfaces. Still not supporting scoped objects

What might this PR break?
anyone downstream dependent on v7 but in terms of splat not much, interface was extended not broken

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #669 (9775277) into main (107548c) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   71.84%   71.83%   -0.02%     
==========================================
  Files          99       99              
  Lines        4717     4732      +15     
==========================================
+ Hits         3389     3399      +10     
- Misses       1328     1333       +5     
Impacted Files Coverage Δ
src/Splat.Prism/SplatContainerExtension.cs 55.22% <40.00%> (+3.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 107548c...9775277. Read the comment docs.

@dpvreony dpvreony marked this pull request as ready for review February 12, 2021 20:28
Copy link
Contributor

@worldbeater worldbeater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably worth throwing NotSupportedException instead of NIE if we aren't supporting scopes?

@dpvreony
Copy link
Member Author

ok will make adjustment

@dpvreony dpvreony merged commit 237f473 into main Mar 6, 2021
@dpvreony dpvreony deleted the prism8 branch March 6, 2021 17:34
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants