Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

3055 do not recreate cx and getValue functions during render of Select component #16

Open
wants to merge 262 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
262 commits
Select commit Hold shift + click to select a range
3f82ae5
Merge pull request #4294 from JedWatson/fix-circle-ci
bladey Nov 23, 2020
442596e
Fix getPortalPlacement in PortalPlacementContext
JedWatson Nov 23, 2020
7720401
Fix menuShouldScrollIntoView in MenuPortal example
JedWatson Nov 23, 2020
7af1aaf
Add changeset
JedWatson Nov 23, 2020
665443b
Merge branch 'master' into fix-menuplacement-context
bladey Nov 23, 2020
709b0bc
Merge pull request #4295 from JedWatson/fix-menuplacement-context
bladey Nov 23, 2020
ca66253
Version Packages
github-actions[bot] Nov 23, 2020
c5937f3
Merge branch 'master' into master
bladey Nov 23, 2020
55b1770
Merge branch 'master' into master
JedWatson Nov 23, 2020
17b406a
Merge pull request #3980 from JedWatson/changeset-release/master
JedWatson Nov 23, 2020
f29e5ca
Merge branch 'master' into master
JedWatson Nov 23, 2020
3b53d7a
Merge pull request #4240 from jayeshmann/master
JedWatson Nov 23, 2020
1ef2517
Bump dot-prop from 4.2.0 to 4.2.1
dependabot[bot] Nov 23, 2020
0bb2de3
Bump tar-fs from 1.16.0 to 1.16.3
dependabot[bot] Nov 23, 2020
2c35314
Merge branch 'master' into master
bladey Nov 27, 2020
ab760f7
Adds review fixes
majgaard Nov 28, 2020
9460a6f
Merge pull request #4296 from JedWatson/dependabot/npm_and_yarn/dot-p…
bladey Dec 2, 2020
c488a78
Merge branch 'master' into dependabot/npm_and_yarn/tar-fs-1.16.3
bladey Dec 2, 2020
3d040c5
Bump websocket-extensions from 0.1.3 to 0.1.4
dependabot[bot] Dec 2, 2020
99b02d7
Merge pull request #4205 from JedWatson/dependabot/npm_and_yarn/webso…
bladey Dec 2, 2020
b54244e
Merge branch 'master' into dependabot/npm_and_yarn/tar-fs-1.16.3
bladey Dec 2, 2020
c4b3090
Merge pull request #4204 from JedWatson/dependabot/npm_and_yarn/tar-f…
bladey Dec 2, 2020
f350b69
Bump node-fetch from 2.6.0 to 2.6.1
dependabot[bot] Dec 2, 2020
2d13c1f
Merge pull request #4212 from JedWatson/dependabot/npm_and_yarn/node-…
bladey Dec 2, 2020
41d683d
Update Creatable.js
bladey Dec 2, 2020
72f6036
Create ten-apples-tap.md
bladey Dec 2, 2020
315de17
Merge branch 'master' into patch-1
bladey Dec 2, 2020
998c979
Merge pull request #4306 from JedWatson/fix-docs-createOptionPosition
ebonow Dec 2, 2020
8ef7ce4
PR#4233-Fix broken example
Dec 6, 2020
4fe4485
Remove UNSAFE_componentWillReceiveProps from Async
Methuselah96 Dec 9, 2020
edc14e4
Remove UNSAFE_componentWillReceiveProps from Creatable
Methuselah96 Dec 9, 2020
4494861
Apply automatic Prettier changes in Select
Methuselah96 Dec 9, 2020
869c10f
Move components to getComponents() getter
Methuselah96 Dec 9, 2020
56824dc
Make menuOptions calculated instead of storing it in state
Methuselah96 Dec 9, 2020
0258620
Move methods necessary for getDerivedStateFromProps out of class
Methuselah96 Dec 9, 2020
42d3518
Fix bug where the isOptionDisabled builtin was incorrectly called
Methuselah96 Dec 9, 2020
d2919c7
Refactor buildMenuOptions and move it out of the class
Methuselah96 Dec 9, 2020
c2a1137
Switch to getDerivedStateFromProps
Methuselah96 Dec 9, 2020
b2488bb
Create purple-moons-promise.md
Methuselah96 Dec 9, 2020
daaad67
Remove unnecessary state parameters
Methuselah96 Dec 9, 2020
c14f591
Preserve indices to match previous behavior
Methuselah96 Dec 9, 2020
13c2b6a
Memoize buildCategorizedOptions
Methuselah96 Dec 9, 2020
ebf1c04
Restore memoization of getComponents()
Methuselah96 Dec 10, 2020
2303fdf
Update changeset
Methuselah96 Dec 10, 2020
384ca8c
Memoize buildFocusableOptions as well
Methuselah96 Dec 10, 2020
ee638d4
Create great-actors-end.md
Methuselah96 Dec 10, 2020
a2172f0
Merge pull request #4316 from JedWatson/#4233-Update-CustomNoOptionsM…
Methuselah96 Dec 10, 2020
b13c7cd
Bump ini from 1.3.5 to 1.3.7
dependabot[bot] Dec 10, 2020
0fb40ab
Merge pull request #4324 from JedWatson/dependabot/npm_and_yarn/ini-1…
Methuselah96 Dec 10, 2020
c03527a
Merge branch 'master' into remove-unsafe-react
Methuselah96 Dec 11, 2020
6f56afe
Merge branch 'master' into patch-1
JedWatson Dec 11, 2020
e97aafc
Merge pull request #4275 from jakeherp/patch-1
JedWatson Dec 11, 2020
7a56e45
Merge branch 'master' into master
JedWatson Dec 11, 2020
c615e93
Added changeset
JedWatson Dec 11, 2020
20e8d5a
Merge pull request #4084 from manvydasu/master
JedWatson Dec 11, 2020
ad890f2
Update react-input-autosize (#4326)
Methuselah96 Dec 11, 2020
24ba870
add innerProps to MenuList (#4289)
slimklim Dec 11, 2020
52ec1c1
Update purple-moons-promise.md
Methuselah96 Dec 12, 2020
a0133f1
Fix removing MultiValues that have identical values. Issue #4137 (#4154)
brenshanny Dec 12, 2020
d1e660c
protect against reading removeEventListener from el if null (#4213)
eythort Dec 12, 2020
482039a
4255: Check props to ensure Select is not focused when isDisabled cha…
Dec 12, 2020
ff0cf1c
Resolves Flow issues
majgaard Dec 17, 2020
27e1c32
Merge branch 'master' into deps/upgrade-emotion
Methuselah96 Dec 17, 2020
82be3a7
Merge branch 'master' into patch-2
Methuselah96 Dec 18, 2020
fcdeb2b
Pass [] instead of null in onChange when no values on multi-select
Methuselah96 Dec 18, 2020
ffb4740
Change
Methuselah96 Dec 18, 2020
0205067
Create dry-pumas-complain.md
Methuselah96 Dec 18, 2020
41c9ebb
#3006: Documentation clarifications and defining components section
Dec 18, 2020
82c82fa
Remove style changes
Methuselah96 Dec 18, 2020
2c0885f
Indecisive
Methuselah96 Dec 18, 2020
571c2cc
Fix linting spaces and semi-colons
Dec 18, 2020
aa01542
Fix test
Methuselah96 Dec 18, 2020
25c9219
Standardize innerProps and className props on customizable components
Methuselah96 Dec 21, 2020
18cfb5e
Reorder
Methuselah96 Dec 21, 2020
b5f9b0c
Create fast-eagles-perform.md
Methuselah96 Dec 21, 2020
076cbc8
Update fast-eagles-perform.md
Methuselah96 Dec 21, 2020
23be4c1
Fix types
Methuselah96 Dec 21, 2020
7206bbb
Fix more types
Methuselah96 Dec 21, 2020
db13938
Revert "Restore memoization of getComponents()"
Methuselah96 Dec 10, 2020
896a845
Merge branch 'master' into remove-unsafe-react
Methuselah96 Dec 23, 2020
8e8397f
Enforce prettier in CI (#4338)
Methuselah96 Jan 13, 2021
b11ffb8
Merge branch 'master' into on-change-null
JedWatson Jan 13, 2021
7bbcbab
Merge branch 'master' into #3006-Documentation-Additions-and-Revisions
JedWatson Jan 13, 2021
cec530e
Merge branch 'master' into menu-portal-class-name
Methuselah96 Jan 13, 2021
90f2e68
Merge branch 'master' into Issue-4255--Remove-focus-from-disabled-Select
JedWatson Jan 13, 2021
9aef92d
Merge branch 'master' into patch-2
Methuselah96 Jan 13, 2021
b28d992
Fix onCreateOption is not always called for Creatable (#3990)
nikitaindik Jan 13, 2021
215e3d9
Merge branch 'master' into Issue-4255--Remove-focus-from-disabled-Select
Methuselah96 Jan 13, 2021
f606436
Merge branch 'master' into patch-2
Methuselah96 Jan 13, 2021
a1b8d84
Merge branch 'master' into menu-portal-class-name
Methuselah96 Jan 13, 2021
db7489e
Add NPM scripts to write and check Prettier
Methuselah96 Jan 13, 2021
94a0bb2
Merge branch 'master' into #3006-Documentation-Additions-and-Revisions
Methuselah96 Jan 13, 2021
17680f6
Make Prettier changes
Methuselah96 Jan 13, 2021
b309ba8
Make Prettier changes
Methuselah96 Jan 13, 2021
2ad29d6
Create quick-carrots-count.md
Methuselah96 Jan 13, 2021
57ed3e3
Pass down extra props to group header as item.data (#3046)
akre54 Jan 13, 2021
a1e1db2
Fix value passed to onChange when clearing values (#4373)
Methuselah96 Jan 13, 2021
a2971e6
Merge branch 'master' into Issue-4255--Remove-focus-from-disabled-Select
JedWatson Jan 13, 2021
ad2ff6c
4255: Check props to ensure Select is not focused when isDisabled cha…
JedWatson Jan 13, 2021
b27d01b
Merge branch 'master' into patch-2
JedWatson Jan 13, 2021
ef2d357
Merge pull request #4136 from jkjustjoshing/patch-2
JedWatson Jan 13, 2021
9c4dec3
Merge branch 'master' into #3006-Documentation-Additions-and-Revisions
JedWatson Jan 13, 2021
500398d
Merge pull request #4340 from JedWatson/#3006-Documentation-Additions…
JedWatson Jan 13, 2021
244fa36
Merge branch 'master' into add-prettify-script
JedWatson Jan 13, 2021
8c3de14
Merge pull request #4374 from Methuselah96/add-prettify-script
JedWatson Jan 13, 2021
4ecdc9b
Version Packages
github-actions[bot] Jan 13, 2021
45f6f29
Merge pull request #4307 from JedWatson/changeset-release/master
JedWatson Jan 13, 2021
cbff9a0
Renames key to cacheKey, updates changeset
majgaard Jan 15, 2021
52b0230
Merge `ScrollBlock` and `ScrollCaptor` into `ScrollManager`
Rall3n Dec 13, 2020
99a2bcb
Resolve linting errors
Rall3n Dec 13, 2020
391a4f6
Missing `lockEnabled` prop in render method
Rall3n Dec 13, 2020
12a2c7a
Remove obsolete components
Rall3n Dec 14, 2020
4674763
Apply prettier changes
Rall3n Jan 17, 2021
b573dca
Swaps jest-emotion for @emotion/jest
majgaard Jan 19, 2021
3977fc4
Merge branch 'master' into remove-unsafe-react
Methuselah96 Jan 20, 2021
a2e4d96
Changes from merge conflict
Methuselah96 Jan 20, 2021
1fec666
Fix typo
Methuselah96 Jan 20, 2021
e7fd12e
useHandle prop on SortableHOC example to prevent dragging on multiVal…
ebonow Jan 20, 2021
70ef91e
Merge branch 'master' into on-change-null
Methuselah96 Jan 20, 2021
07a3997
Update
Methuselah96 Jan 20, 2021
5de4087
Merge branch 'master' into menu-portal-class-name
Methuselah96 Jan 20, 2021
5dd8381
Remove memoization of buildMenuOptions
Methuselah96 Jan 20, 2021
2e8473b
Prettier wants a comma
ebonow Jan 20, 2021
2d5496d
Create beige-eagles-jog.md
Methuselah96 Jan 20, 2021
ed61064
fix data reference
ebonow Jan 20, 2021
0dbf043
Add changeset
ebonow Jan 20, 2021
7cdb8a6
Pass and sanitize CommonProps passed to Group and Input
ebonow Jan 21, 2021
d36a27f
Merge branch 'master' into deps/upgrade-emotion
JedWatson Jan 22, 2021
fd12983
Update olive-toys-try.md
Methuselah96 Jan 22, 2021
cb4b948
Merge pull request #4339 from Methuselah96/on-change-null
JedWatson Jan 22, 2021
e5151bb
Merge branch 'master' into deps/upgrade-emotion
JedWatson Jan 22, 2021
c7041f2
Merge pull request #4283 from majgaard/deps/upgrade-emotion
JedWatson Jan 22, 2021
7d7cbe4
Merge branch 'master' into remove-unsafe-react
JedWatson Jan 22, 2021
ed3fe2e
Merge branch 'master' into findDOMNode-ScrollManager
Methuselah96 Jan 22, 2021
6db74e1
Update import for Emotion v11
Methuselah96 Jan 22, 2021
b132a87
Make ScrollManager a functional component
Methuselah96 Jan 22, 2021
fd93b6a
eslint-plugin-react-hooks
Methuselah96 Dec 11, 2020
e0335ef
Remove useCallback
Methuselah96 Jan 22, 2021
cc7cf9b
Finish useScrollCapture
Methuselah96 Jan 22, 2021
e406c87
Finish useScrollLock
Methuselah96 Jan 20, 2021
eb00026
Cleanup
Methuselah96 Jan 22, 2021
1c60ba4
Merge pull request #4313 from Methuselah96/remove-unsafe-react
JedWatson Jan 22, 2021
ff74140
Merge branch 'master' into remove-build-menu-options-memoization
Methuselah96 Jan 22, 2021
0e4634b
Merge pull request #4388 from Methuselah96/remove-build-menu-options-…
JedWatson Jan 22, 2021
28ee545
Merge branch 'master' into findDOMNode-ScrollManager
JedWatson Jan 22, 2021
7c54eb1
Merge pull request #4330 from Rall3n/findDOMNode-ScrollManager
JedWatson Jan 22, 2021
4bcfb1b
Merge branch 'master' into scroll-manager-hooks
JedWatson Jan 22, 2021
c6f4b74
Merge pull request #4333 from Methuselah96/scroll-manager-hooks
JedWatson Jan 22, 2021
4f9eccd
Cleaning up old TODOs
JedWatson Jan 22, 2021
0071ff2
Delete .sweet-changelogs.js
JedWatson Jan 22, 2021
454b788
Update copyright and credits
JedWatson Jan 22, 2021
c8649e5
Minor website styling fix
JedWatson Jan 22, 2021
55d0687
Update README.md
JedWatson Jan 22, 2021
e297aa1
Run prettier
JedWatson Jan 22, 2021
5baba46
Version Packages
github-actions[bot] Jan 22, 2021
4da6ee0
Merge pull request #4392 from JedWatson/changeset-release/master
JedWatson Jan 22, 2021
19b7634
Add `removedValues` into `onChange` `clear` action meta
eugenet8k Jan 21, 2020
645feb3
Fix key for options within groups (#4396)
Methuselah96 Jan 22, 2021
e7bafee
Version Packages (#4397)
github-actions[bot] Jan 22, 2021
dc9f1b2
Merge branch 'master' into clear-action-arguments
eugenet8k Jan 22, 2021
44f285b
Fix building focusable options from groups (#4399)
Methuselah96 Jan 22, 2021
a62f1aa
Version Packages (#4400)
github-actions[bot] Jan 22, 2021
5bf8f67
aira-live branch changes applied to react-select branch v4.0.2
ebonow Jan 24, 2021
7b7e413
Update custom aria message example
ebonow Jan 24, 2021
36ba1d3
Add test coverage for accessilibity when isMulti
ebonow Jan 25, 2021
b3f0860
Merge branch 'master' into clear-action-arguments
eugenet8k Jan 25, 2021
6e7fead
Remove dependency on @emotion/css
Methuselah96 Jan 26, 2021
10b5f5a
Create pretty-carpets-mix.md
Methuselah96 Jan 26, 2021
7532d4d
Merge pull request #4404 from Methuselah96/remove-emotion-css
JedWatson Jan 26, 2021
2baf5a9
Refactor to move all accessibility functionality to new LiveRegion c…
ebonow Feb 1, 2021
57a9f65
Minor clean-up of comments
ebonow Feb 1, 2021
02e788a
selected may be null onClear
ebonow Feb 1, 2021
aef1b8a
Merge branch 'master' into aria-messages-v4
ebonow Feb 1, 2021
b0e999e
Enhancement: added npm install instructions.
JaydenElliott Feb 2, 2021
5f0f2ec
Bump dependency on @babel/runtime
Methuselah96 Feb 4, 2021
a016c87
Create lovely-dingos-own.md
Methuselah96 Feb 4, 2021
d81ef3f
Only include focusable options from group
Methuselah96 Feb 4, 2021
a8724c4
Add test
Methuselah96 Feb 4, 2021
f600d13
Create eighty-lemons-happen.md
Methuselah96 Feb 4, 2021
d48fafa
Merge pull request #4422 from Methuselah96/fix-focusable-options
JedWatson Feb 4, 2021
63bb04a
Update lovely-dingos-own.md
Methuselah96 Feb 4, 2021
3fd3b8e
Update lovely-dingos-own.md
Methuselah96 Feb 4, 2021
a496e40
Merge branch 'master' into babel-runtime
JedWatson Feb 4, 2021
7c44a99
Merge pull request #4420 from Methuselah96/babel-runtime
JedWatson Feb 4, 2021
11aea80
Merge branch 'master' into menu-portal-class-name
JedWatson Feb 4, 2021
57d6c3c
Merge pull request #4342 from Methuselah96/menu-portal-class-name
JedWatson Feb 4, 2021
5872930
Update pink-cats-mate.md
JedWatson Feb 4, 2021
43c8330
Merge branch 'master' into clear-action-arguments
JedWatson Feb 4, 2021
ee4527c
Merge pull request #3911 from eugenet8k/clear-action-arguments
JedWatson Feb 4, 2021
7b7920b
Merge branch 'master' into sortable-select-example
JedWatson Feb 4, 2021
2c5bbc1
Merge pull request #4387 from JedWatson/sortable-select-example
JedWatson Feb 5, 2021
0a84b7b
Merge branch 'master' into master
JedWatson Feb 5, 2021
ae79eed
Remove browser alias fields
Methuselah96 Feb 5, 2021
dce3863
Create perfect-pandas-argue.md
Methuselah96 Feb 5, 2021
335ca17
Update caniuse-lite browserlist
ebonow Feb 6, 2021
12a18e7
Render single context node, add recommended attributes per #3353
ebonow Feb 6, 2021
f5fe8f9
Do not add mention options count if menuIsClosed per issue #4411
ebonow Feb 6, 2021
b41ba23
Fixed typo in Option docs (#4406)
Reflex-Gravity Feb 6, 2021
6f0b424
Version Packages (#4405)
github-actions[bot] Feb 7, 2021
9801a7f
Announce menu option is selected if focused, add tests. Resolves issu…
ebonow Feb 7, 2021
7efc106
search for option in selectValue
ebonow Feb 7, 2021
36cb3c1
Merge branch 'master' into master
JaydenElliott Feb 7, 2021
c955415
Deeclare event listeners as non-passive to remove Chrome browser warn…
ebonow Feb 8, 2021
0680ae6
Merge branch 'master' into add-non-passive-event-listeners
ebonow Feb 8, 2021
2962385
Merge pull request #4417 from JaydenElliott/master
JedWatson Feb 9, 2021
8ae245b
Use accessor props to get value and label in `compareOption`
Rall3n Feb 9, 2021
9aaf35b
Add polyfill for passive event listeners
ebonow Feb 10, 2021
7c19c99
Allow tabIndex type to be number or string
ebonow Feb 10, 2021
ec7c072
Add changeset
ebonow Feb 10, 2021
2ffed9c
Add changeset
Rall3n Feb 11, 2021
3c3145c
Fix typo in `docs/pages/components`
hazem3500 Feb 16, 2021
88cb46a
Merge pull request #4444 from Rall3n/compare-option-accessors
JedWatson Feb 18, 2021
7891f32
Merge branch 'master' into add-non-passive-event-listeners
JedWatson Feb 18, 2021
258dde1
Add aria-live prop to customize attribute on LiveRegion
ebonow Feb 21, 2021
4fb7988
update snapshots
ebonow Feb 21, 2021
7e588e5
export defaultAriaLiveMessages as object
ebonow Feb 22, 2021
e5f6f93
switch to useMemo instead of useState and get some props from selectP…
ebonow Feb 26, 2021
cb21926
Refactor formatting functions to have one object prop, add prop comments
ebonow Mar 1, 2021
6585829
Fix props typo
ebonow Mar 1, 2021
711967a
Merge pull request #4437 from JedWatson/add-non-passive-event-listeners
JedWatson Mar 4, 2021
25a27d8
Merge branch 'master' into add_missing_create_option_meta
JedWatson Mar 4, 2021
77b61f3
rollback lockfile
ebonow Mar 4, 2021
f4aaf24
Merge branch 'master' into aria-messages-v4
JedWatson Mar 4, 2021
2584428
Merge branch 'master' into remove-browser-alias-fields
JedWatson Mar 4, 2021
ddf1043
Merge branch 'master' into clean-common-props
JedWatson Mar 4, 2021
f9b2015
Merge pull request #4414 from ebonow/aria-messages-v4
JedWatson Mar 4, 2021
838bd69
Fixed formatting
JedWatson Mar 4, 2021
77529b5
Merge branch 'master' into memoize-strip-diacritics-for-input
JedWatson Mar 4, 2021
1e73e5c
Merge pull request #3827 from JedWatson/memoize-strip-diacritics-for-…
JedWatson Mar 4, 2021
8543862
Merge branch 'master' into tab-index-as-number-type
JedWatson Mar 4, 2021
fb12db2
Merge pull request #4443 from JedWatson/tab-index-as-number-type
JedWatson Mar 4, 2021
fbd5ace
Merge branch 'master' into remove-browser-alias-fields
Methuselah96 Mar 5, 2021
e9781b4
Merge branch 'master' into clean-common-props
Methuselah96 Mar 5, 2021
46f7022
Merge branch 'master' into add_missing_create_option_meta
Methuselah96 Mar 5, 2021
37264a1
Merge pull request #3875 from andreme/add_missing_create_option_meta
JedWatson Mar 5, 2021
b8f9ec7
Merge branch 'master' into remove-browser-alias-fields
Methuselah96 Mar 5, 2021
52a27c5
Merge branch 'master' into clean-common-props
Methuselah96 Mar 5, 2021
1978819
Merge pull request #4423 from Methuselah96/remove-browser-alias-fields
JedWatson Mar 5, 2021
665f7ae
Merge branch 'master' into clean-common-props
Methuselah96 Mar 5, 2021
55b1432
Merge pull request #4391 from JedWatson/clean-common-props
JedWatson Mar 5, 2021
4afd78a
Version Packages
github-actions[bot] Mar 5, 2021
ef2090e
Merge pull request #4449 from JedWatson/changeset-release/master
ebonow Mar 5, 2021
ce1e3ad
Merge branch 'master' into patch-1
JedWatson Mar 5, 2021
cf170ca
Merge pull request #4445 from hazem3500/patch-1
JedWatson Mar 5, 2021
ed8b85f
Ensure window exists in passive events pollyfill
ebonow Mar 5, 2021
ca3c41b
Adding changeset
ebonow Mar 5, 2021
c630e24
Merge branch 'master' into check-window-exists-in-passive-events-poll…
ebonow Mar 5, 2021
fd9fa23
Merge pull request #4478 from JedWatson/check-window-exists-in-passiv…
ebonow Mar 5, 2021
3ae57af
Version Packages
github-actions[bot] Mar 5, 2021
56be61b
Merge pull request #4479 from JedWatson/changeset-release/master
ebonow Mar 5, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/react-select/src/Select.js
Original file line number Diff line number Diff line change
Expand Up @@ -742,14 +742,15 @@ export default class Select extends Component<Props, State> {
};
}

getValue = () => this.state.selectValue;

cx = (...args: any) => classNames(this.props.classNamePrefix, ...args);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cx = (...args: any) => classNames(this.props.classNamePrefix, ...args);
cx = (...args: Array<any>) => classNames(this.props.classNamePrefix, ...args);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better yet:

Suggested change
cx = (...args: any) => classNames(this.props.classNamePrefix, ...args);
cx = (state?: ClassNamesState, className?: string) => classNames(this.props.classNamePrefix, state, className);


getCommonProps() {
const { clearValue, getStyles, setValue, selectOption, props } = this;
const { classNamePrefix, isMulti, isRtl, options } = props;
const { selectValue } = this.state;
const { clearValue, cx, getStyles, getValue, setValue, selectOption, props } = this;
const { isMulti, isRtl, options } = props;
const hasValue = this.hasValue();
const getValue = () => selectValue;

const cx = classNames.bind(null, classNamePrefix);
return {
cx,
clearValue,
Expand Down