This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
3055 do not recreate cx and getValue functions during render of Select component #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e2b1af8:
|
|
Thanks! Can you add a changeset? |
Methuselah96
suggested changes
Nov 18, 2020
| @@ -742,14 +742,15 @@ export default class Select extends Component<Props, State> { | |||
| }; | |||
| } | |||
|
|
|||
| getValue = () => this.state.selectValue; | |||
|
|
|||
| cx = (...args: any) => classNames(this.props.classNamePrefix, ...args); | |||
There was a problem hiding this comment.
Suggested change
| cx = (...args: any) => classNames(this.props.classNamePrefix, ...args); | |
| cx = (...args: Array<any>) => classNames(this.props.classNamePrefix, ...args); |
Methuselah96
suggested changes
Nov 18, 2020
| @@ -742,14 +742,15 @@ export default class Select extends Component<Props, State> { | |||
| }; | |||
| } | |||
|
|
|||
| getValue = () => this.state.selectValue; | |||
|
|
|||
| cx = (...args: any) => classNames(this.props.classNamePrefix, ...args); | |||
There was a problem hiding this comment.
Or better yet:
Suggested change
| cx = (...args: any) => classNames(this.props.classNamePrefix, ...args); | |
| cx = (state?: ClassNamesState, className?: string) => classNames(this.props.classNamePrefix, state, className); |
Fix breaking CircleCI / Cypress build
…ster Version Packages
Updated copyright in multiple places for year 2020
Bumps [dot-prop](https://github.com/sindresorhus/dot-prop) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/sindresorhus/dot-prop/releases) - [Commits](sindresorhus/dot-prop@v4.2.0...v4.2.1) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 1.16.0 to 1.16.3. - [Release notes](https://github.com/mafintosh/tar-fs/releases) - [Commits](mafintosh/tar-fs@v1.16.0...v1.16.3) Signed-off-by: dependabot[bot] <support@github.com>
…arn/dot-prop-4.2.1 Bump dot-prop from 4.2.0 to 4.2.1
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com>
…arn/websocket-extensions-0.1.4 Bump websocket-extensions from 0.1.3 to 0.1.4
…arn/tar-fs-1.16.3
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com>
…arn/node-fetch-2.6.1
Co-Authored-By: Eric Bonow <1007579+ebonow@users.noreply.github.com>
Aria Live Configuration
…tics-for-input Memoize strip diacritics for input
…type tabIndex as number type
…ion_meta Creatable: Add option meta field to onChange for 'create-option' action
…ias-fields Remove browser alias fields
Pass and sanitize commonProps passed to GroupHeader and Input
…ster Version Packages
Fix typo in `docs/pages/components`
…in-passive-events-pollyfill Ensure window exists in passive events polyfill
…ster Version Packages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.