feat: Deprecate unstable_reactLegacyComponentNames
#2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
requested review from
cipolleschi
and removed request for
thymikee and
adamTrz
thymikee
reviewed
Jan 16, 2024
docs/projects.md
Outdated
| @@ -91,7 +89,7 @@ Array of strings that will be passed to the `npx react-native run-ios` command w | |||
|
|
|||
| #### project.ios.unstable_reactLegacyComponentNames | |||
|
|
|||
| > Note: Only applicable when new architecture is turned on. | |||
| > Note: Deprecated in React Native 0.74. Only applicable when new architecture is turned on. | |||
There was a problem hiding this comment.
Is there a PR that adds this to iOS as well? Currently facebook/react-native#42294 refers to Android only
|
Added a warning that surfaces whenever config is read (e.g. for 
If you confirm this is also what happens for iOS, I'll add it there as well |
cipolleschi
approved these changes
Jan 16, 2024
|
Found this for iOS: facebook/react-native#41656 |
thymikee
force-pushed
the
nc/automatic-interop
branch
from
325006d
to
eb4e53c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Related to:
With RN 0.74 specifying the legacy components name wont' be necessary anymore as the framework will detect it automatically.
Test Plan:
Not sure how to test this. I'm basically ignoring the
unstable_reactLegacyComponentNames. We can remove this in 0.75Checklist