Fabric Automatic Interop for Android #42294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This changes enables the Fabric Intrerop Layer automatically for all the users. Practically I'm removing the fallback `ComponentDescriptor` inside the `ComponentDescriptorRegistry` so that if a component hasn't been automatically registered by a user, instead of showing the UnimplementedView, it loads a `UnstableLegacyViewManagerAutomaticComponentDescriptor`. This ComponentDescriptor is built starting from the legacy component name, and responds with correct `ComponentName` and `ComponentHandle` (similarly to the `UnstableLegacyViewManagerInteropComponentDescriptor` but without using C++ templates). Changelog: [Internal] [Changed] - Fabric Automatic Interop for Android Differential Revision: D52663244
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52663244 |
2 tasks
Base commit: af70594 |
|
This pull request has been merged in 748d674. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This changes enables the Fabric Intrerop Layer automatically for all the users.
Practically I'm removing the fallback
ComponentDescriptorinside theComponentDescriptorRegistryso that if a component hasn't been automatically registered by a user, instead of showing the UnimplementedView, it loads aUnstableLegacyViewManagerAutomaticComponentDescriptor.This ComponentDescriptor is built starting from the legacy component name, and responds with correct
ComponentNameandComponentHandle(similarly to theUnstableLegacyViewManagerInteropComponentDescriptorbut without using C++ templates).Changelog:
[Internal] [Changed] - Fabric Automatic Interop for Android
Differential Revision: D52663244