Improve Quotation and Path Handling in CLI Tools #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
approved these changes
Jan 2, 2024
|
Thank you! 🙏 In initial implementation quotes were there, so dunno why we removed it 😅 |
|
hey @snowleopard17, can I ask why did you close the PR? 🧐 was it missclick? |
|
@szymonrybczak Hey sorry first PR, so I thought after getting approved we suppose to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses compatibility issues with the 'make run-android' command in various shell environments. The changes ensure consistent behavior across different shells by improving path handling and quoting. Specifically, the modifications in 'launchPackager.command' and 'startServerInNewWindow.ts' include enclosing paths with spaces in double quotes and refining the quoting of variables.