Improve Quotation and Path Handling in CLI Tools (#2238)

react-native-community · Jan 3, 2024 · 0e8cf75 · 0e8cf75
1 parent f22be6d
commit 0e8cf75
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/cli-tools/src/launchPackager.command b/packages/cli-tools/src/launchPackager.command
@@ -3,8 +3,8 @@
 THIS_DIR=$(cd -P "$(dirname "$(readlink "${BASH_SOURCE[0]}" || echo "${BASH_SOURCE[0]}")")" && pwd)
 
 source "$THIS_DIR/.packager.env"
-cd $PROJECT_ROOT
-$REACT_NATIVE_PATH/cli.js start --port $RCT_METRO_PORT
+cd "$PROJECT_ROOT"
+"$REACT_NATIVE_PATH/cli.js" start --port $RCT_METRO_PORT
 
 if [[ -z "$CI" ]]; then
   echo "Process terminated. Press <enter> to close the window"

diff --git a/packages/cli-tools/src/startServerInNewWindow.ts b/packages/cli-tools/src/startServerInNewWindow.ts
@@ -27,7 +27,7 @@ function startServerInNewWindow(
   const packagerEnvFilename = isWindows ? '.packager.bat' : '.packager.env';
   const packagerEnvFileExportContent = isWindows
     ? `set RCT_METRO_PORT=${port}\nset PROJECT_ROOT=${projectRoot}\nset REACT_NATIVE_PATH=${reactNativePath}`
-    : `export RCT_METRO_PORT=${port}\nexport PROJECT_ROOT=${projectRoot}\nexport REACT_NATIVE_PATH=${reactNativePath}`;
+    : `export RCT_METRO_PORT=${port}\nexport PROJECT_ROOT="${projectRoot}"\nexport REACT_NATIVE_PATH="${reactNativePath}"`;
   const nodeModulesPath = resolveNodeModuleDir(projectRoot, '.bin');
   const cliPluginMetroPath = path.join(
     path.dirname(