Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove error when main activity not found in AndroidManifest.xml #2187

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Sometimes there are really complicated setups, like this one - that are based on native_modules.gradle, so are based on config command. We should not block users in these cases.

Test Plan:

CI

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak szymonrybczak force-pushed the fix/remove-error-when-main-activity-not-found branch from c1080ad to 0cd12d8 Compare November 29, 2023 18:15
@szymonrybczak
Copy link
Collaborator Author

Ugh, CI failing because flaky unit test - not related to changes.

@szymonrybczak szymonrybczak force-pushed the fix/remove-error-when-main-activity-not-found branch from 0cd12d8 to 5edd823 Compare November 30, 2023 10:54
@szymonrybczak szymonrybczak force-pushed the fix/remove-error-when-main-activity-not-found branch from 5edd823 to 2a49186 Compare November 30, 2023 10:59
@thymikee thymikee merged commit 42ab1e0 into main Nov 30, 2023
9 of 10 checks passed
@thymikee thymikee deleted the fix/remove-error-when-main-activity-not-found branch November 30, 2023 13:06
@alperenkarip
Copy link

Hello, what did you do for this situation? I'm getting this error after the 0.73 update @szymonrybczak

@rupeshkk-iprogrammer
Copy link

we are also facing this error in rn0.73.0
error Main activity not found in /AndroidManifest.xml.

@TMisiukiewicz
Copy link
Collaborator

Hey @alperenkarip @rupeshkk-iprogrammer unfortunately this fix was not picked for 0.73 - it should land with 0.73.1 (should happen soon)

@KrisLau
Copy link

KrisLau commented Feb 4, 2025

I'm still getting this error and I have a MainActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants